Try to disable the GC in DMCompiler #2070
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I'd like to try reducing the largest allocators before doing this. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to disable the garbage collector during compilation if sufficient memory is available. It's no guarantee and it's currently set to disable the GC if ~4.5 GB is available. This is to give us some breathing room on top of the ~3.9 GB of total allocs for compiling TG currently.
Note that this memory value does not cause it to allocate the specified amount of memory nor cause any sort of issues if that amount of memory isn't available. It'll just run the GC in that case.
This takes TG from a consistent 22s down to 18s on my machine, and Paradise from 13s to 11s.
Added a
--use-gccompiler arg if people want the old behavior for some reason.