Makes DMCompiler non-static. Yes, really.
#2075
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
InspectCode found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
# Conflicts: # Content.Tests/DMTests.cs # DMCompiler/Compiler/DM/DMParser.cs # DMCompiler/Compiler/DMM/DMMParser.cs # DMCompiler/Compiler/DMPreprocessor/DMPreprocessor.cs # DMCompiler/Compiler/DMPreprocessor/DMPreprocessorLexer.cs # DMCompiler/DM/Builders/DMExpressionBuilder.cs # DMCompiler/DM/Builders/DMObjectBuilder.cs # DMCompiler/DM/Builders/DMProcBuilder.cs # DMCompiler/DM/DMExpression.cs # DMCompiler/DM/DMObject.cs # DMCompiler/DM/DMObjectTree.cs # DMCompiler/DM/DMProc.cs # DMCompiler/DM/DMValueType.cs # DMCompiler/DM/Expressions/Builtins.cs # DMCompiler/DM/Expressions/Constant.cs # DMCompiler/DM/Expressions/Dereference.cs # DMCompiler/DM/Expressions/Procs.cs # DMCompiler/DMCompiler.cs # DMCompiler/DreamPath.cs
Copy-pasting `DMCompiler compiler, DMObject dmObject, DMProc proc` everywhere was ridiculous
Unnecessary and wasteful on memory
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
wixoaGit
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1829
DMCompileris no longer static. Yes, really.Is this code perfect? Haha, no.
Does this PR make any other changes to take advantage of
DMCompilerno longer being static? Also no!This is just the grunt work to make it compile and continue functioning. Please for the love of my sanity let's ship the minimum viable product and work on improving it later.
It does work though!
