Compiletime rgb() evaluation#2115
Merged
wixoaGit merged 9 commits intoOpenDreamProject:masterfrom Aug 22, 2025
Merged
Conversation
boring-cyborg
bot
added
Client
ike709
changed the title
rgb() evaluationrgb() evaluation
ike709
commented
Nov 30, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
wixoaGit
requested changes
Jan 16, 2025
Member
wixoaGit
left a comment
wixoaGit
left a comment
There was a problem hiding this comment.
This breaks rgb(r=1, 2, 3). It should give #010203 but it instead gives #010000.
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
…lergb # Conflicts: # DMCompiler/SharedOperations.cs # OpenDreamRuntime/Procs/DMOpcodeHandlers.cs
Code was in the wrong block
wixoaGit
approved these changes
Aug 22, 2025
| ColorHelpers.ColorSpace space = ColorHelpers.ColorSpace.RGB; | ||
|
|
||
| if (arguments.Item1 != null) { | ||
| string result = "#000000"; |
Check warning
Code scanning / InspectCode
Assignment is not used Warning
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rgb()is supposed to be considered a constant when its args are constant, as shown in the included unit test which passes in BYOND.To facilitate this,
rgb()handling has been moved to the compiler and theDMExpressionnow implementsTryAsConstant().As a bonus, the peephole optimizer will attempt to evaluate it at compiletime whenever
Rgb's argtype isFromStackand its argcount matches a precedingPushNFloatscount. That means we'll compiletime eval something likergb(255,255,255)but notrgb(255,255,255, space=foo()).