Conversation
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
There was a problem hiding this comment.
InspectCode found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
I haven't done a thorough look through the code yet, but I tried testing this by booting up Paradise and shooting a girder. This should create some particles, but it broke the renderer instead. Some planes stopped rendering and there were errors every frame. |
|
Ah that's because I hadn't implemented the generator type and had it throw instead - my bad, I just need to figure out the math and implement |
And some other small changes
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
…rticles_od # Conflicts: # OpenDream.slnx
Done but requires tweaks to match behaviour perfectly.
Screencast from 2025-06-30 21-34-22.webm
Implements
/atom/movable/particles,/particles, and/generatorFixes #2143
#2194