Skip to content

Comments

Particles#2219

Merged
wixoaGit merged 60 commits intoOpenDreamProject:masterfrom
amylizzle:particles_od
Sep 30, 2025
Merged

Particles#2219
wixoaGit merged 60 commits intoOpenDreamProject:masterfrom
amylizzle:particles_od

Conversation

@amylizzle
Copy link
Collaborator

@amylizzle amylizzle commented Feb 18, 2025

Done but requires tweaks to match behaviour perfectly.
Screencast from 2025-06-30 21-34-22.webm

Implements /atom/movable/particles, /particles, and /generator

Fixes #2143

#2194

@boring-cyborg boring-cyborg bot added Client Involves the OpenDream client Runtime Involves the OpenDream server/runtime labels Feb 18, 2025
@boring-cyborg boring-cyborg bot added the Compiler Involves the OpenDream compiler label Feb 18, 2025
@github-actions github-actions bot added size/XL and removed size/L labels Feb 18, 2025
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added size/XXL and removed size/XL labels Feb 20, 2025
@amylizzle amylizzle marked this pull request as ready for review August 20, 2025 15:39
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

InspectCode found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@amylizzle amylizzle changed the title Particles: OD side Particles Aug 20, 2025
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@wixoaGit
Copy link
Member

I haven't done a thorough look through the code yet, but I tried testing this by booting up Paradise and shooting a girder. This should create some particles, but it broke the renderer instead. Some planes stopped rendering and there were errors every frame.

@amylizzle
Copy link
Collaborator Author

Ah that's because I hadn't implemented the generator type and had it throw instead - my bad, I just need to figure out the math and implement

@amylizzle amylizzle requested a review from wixoaGit September 3, 2025 20:10
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@wixoaGit wixoaGit enabled auto-merge (squash) September 30, 2025 05:31
@wixoaGit wixoaGit merged commit 6caf227 into OpenDreamProject:master Sep 30, 2025
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Client Involves the OpenDream client Compiler Involves the OpenDream compiler Runtime Involves the OpenDream server/runtime size/XXL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

/particle is not implemented

2 participants