Skip to content

Comments

Remove all /atoms from tests#2372

Merged
wixoaGit merged 6 commits intoOpenDreamProject:masterfrom
amylizzle:clean_up_tests
Sep 21, 2025
Merged

Remove all /atoms from tests#2372
wixoaGit merged 6 commits intoOpenDreamProject:masterfrom
amylizzle:clean_up_tests

Conversation

@amylizzle
Copy link
Collaborator

Fixes #1142

The vast majority were just find/replace, only a few needed any attention paying

Affected tests were found by forcing DreamObjectAtom to throw on creation.

@github-actions
Copy link

github-actions bot commented Sep 1, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link
Member

@wixoaGit wixoaGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The term obj is used in a bunch of filenames and var/proc names, those should probably be renamed to datum.

@amylizzle
Copy link
Collaborator Author

The term obj is used in a bunch of filenames and var/proc names, those should probably be renamed to datum.

eh, /datum is a DreamObject, the distinction is largely meaningless

@wixoaGit wixoaGit merged commit 511b8dc into OpenDreamProject:master Sep 21, 2025
19 checks passed
@amylizzle amylizzle deleted the clean_up_tests branch September 21, 2025 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unit tests should not reference /atom or its descendants

2 participants