-
Notifications
You must be signed in to change notification settings - Fork 127
Implement generator.Rand()
#2459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
9ceb755
Implement `generator.Rand()`
e1e0675
remove unimplemented warning
95c409c
oops
ike709 88af42b
Update OpenDreamRuntime/Procs/Native/DreamProcNativeGenerator.cs
ike709 cd745b8
Update OpenDreamRuntime/Procs/Native/DreamProcNativeGenerator.cs
ike709 4ffea37
Update OpenDreamRuntime/Procs/Native/DreamProcNativeGenerator.cs
ike709 d6a01ac
review
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| /proc/RunTest() | ||
| var/generator/gen = generator("num", -1, 1) | ||
| var/result = gen.Rand() | ||
| ASSERT(isnum(result)) | ||
| ASSERT((result >= -1 || result <= 1)) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| using OpenDreamRuntime.Objects; | ||
| using OpenDreamRuntime.Objects.Types; | ||
| using OpenDreamShared.Dream; | ||
| using Robust.Shared.Random; | ||
|
|
||
| namespace OpenDreamRuntime.Procs.Native; | ||
|
|
||
| internal static class DreamProcNativeGenerator { | ||
| [DreamProc("Rand")] | ||
| public static DreamValue NativeProc_Rand(NativeProc.Bundle bundle, DreamObject? src, DreamObject? usr) { | ||
| DreamObjectGenerator genObj = (DreamObjectGenerator)src!; | ||
|
|
||
| switch (genObj.Generator) | ||
| { | ||
| case GeneratorNum numGen: | ||
| { | ||
ike709 marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| var result = numGen.Generate(IoCManager.Resolve<IRobustRandom>()); | ||
| return new DreamValue(result); | ||
| } | ||
| case GeneratorBox2: | ||
| case GeneratorVector2: | ||
| case GeneratorCircle: | ||
| case GeneratorSquare: | ||
ike709 marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| { | ||
ike709 marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| var vecGen = (IGeneratorVector)genObj.Generator; | ||
| var resultVector = vecGen.GenerateVector2(IoCManager.Resolve<IRobustRandom>()); | ||
| var resultObj = DreamObjectVector.CreateFromValue(resultVector, bundle.ObjectTree); | ||
| return new DreamValue(resultObj); | ||
| } | ||
| case GeneratorBox3: | ||
| case GeneratorVector3: | ||
| case GeneratorSphere: | ||
| case GeneratorCube: | ||
| { | ||
ike709 marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| var vecGen = (IGeneratorVector)genObj.Generator; | ||
| var resultVector = vecGen.GenerateVector3(IoCManager.Resolve<IRobustRandom>()); | ||
| var resultObj = DreamObjectVector.CreateFromValue(resultVector, bundle.ObjectTree); | ||
| return new DreamValue(resultObj); | ||
| } | ||
| default: | ||
| throw new Exception($"Invalid generator for Rand: {genObj}"); | ||
| } | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.