Implement several *_char function wrappers #2475
Merged
+98
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Opendream defaults to text manipulation using UTF-16 char counts. In byond only *_char functions do this. Therefor these are all just wrappers for the existing non_char procs. Adds proc support for: findtext_char findtextEx_char findlasttext_char findlasttextEx_char replacetext_char replacetextEx_char nonspantext_char splittext_char
Sorrowfulwinds
changed the title
Boilerplate stuff so the compiler actually uses the procs Touchup proc/splittext() in _Standard.dm it was missing vars.
Contributor
Author
|
I think I have added the new functions to all the necessary lists. I removed the compiler warnings for these functions and they do compile and return the correct values on a simple test. |
wixoaGit
approved these changes
Dec 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for 8 *_char() procs from #2194
It looks like the OpenDream project has settled on text manipulation procs indexing by character and not the byond-default byte indexing. This means that they all function identically to the *_char versions in byond. So these added functions are just wrappers for their non_char versions.
Adds the following proc support:
findtext_char
findtextEx_char
findlasttext_char
findlasttextEx_char
replacetext_char
replacetextEx_char
nonspantext_char
splittext_char
I did a simple test to confirm these share the same results in both this PR of OD and 516.1673 of byond. There is no actual new logic added with this PR so the test is purely for functionality confirmation.