Fix start time logic #233
Merged
Fix start time logic #233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll try, but I have yet to successfully modify and run that modified docker image 😬 |
Member
Author
|
You could also just hot-patch the Windows native version by manually modifying the lines in |
Contributor
|
Currently testing with the banana dataset and it doesn't fix WebODM's 1152: Modified directly on the docker node and confirmed modification. |
Member
Author
|
Thanks for testing; just to make sure, you did restart the node.js process after modifying the file? |
Contributor
|
Oooh, I did not. Rerunning now. |
Contributor
|
Bingo: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix OpenDroneMap/WebODM#1152
@Saijin-Naib if you have time, could you try to reproduce the issue you reported on 1152 (using the NodeODM UI), then apply the changes in this PR and verify that it solves the issue? 🙏