-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add pipeline option groups and enhance EditPresetDialog UI #1820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Love this idea and your implementation! |
|
This looks phenomenal and helps lower the first-start barrier for sure. Is it still able to be screenread and navigated by keyboard (tabbing, etc)? |
|
Keyboard navigation is consistent with the original implementation; tab stops on the text boxes but not on the checkboxes. This is not correct but it is unrelated to the changes I introduced. |
|
Thanks @thadwald! Looks like it could be a good improvement for making the options list more readable. Did you use LLMs / code agents to write this? |
|
I made a slight change to the group names and icons. @pierotofy I used Claude.ai.
|
|
This should be tested with NodeMicMac (which has different options that NodeODM) and Lightning (which uses LGT and does not have the same number of options as NodeODM). Also, I'm worried about the use of some esoteric CSS and JS functions that claude picked that might not work in all browsers, so this needs manual testing (have you tested mobile and desktop browsers?) Most importantly, and I knew this would happen, here we are, with a useful contribution that people want, but by dubious self-imposed rules I cannot merge it. OpenDroneMap/documents#3 |
|
It's a valid concern. Yes, it's doggedly persistent in creating buggy code, but It's also a great tool for spotting bugs and typos. For the record, all of my submissions to the Open Drone Map project have involved IA. Some are simple, others aren't. My suggestion (for what it's worth) is to not ban it outright, but to vet every single line. And in the case that you cannot reconcile the use of AI at all, here's a great idea for future development of WebODM! If you look closely, you'll see handling of options not in NodeODM, that I added to my local NodeODM. So it handles missing options well. |



This enhancement is my effort to organize the array of processing options in WebODM. The intent is to achieve the the following:
This makes each feature easier to find. More importantly, it communicates the pipeline order and how each option fits into this order. This should help to flatten the learning curve for the tool.
I also included a search feature to aid in quickly finding an option, as well as an option for reverting to the traditional A-Z flat view.
Screen shots: