Skip to content

Set base path in @RestController to simplify route definitions #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Jaoovit wants to merge 1 commit into from
Closed

Set base path in @RestController to simplify route definitions #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions src/main/java/com/openelements/issues/ApiEndpoint.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,12 @@
import org.jspecify.annotations.NonNull;
import org.slf4j.Logger;
import org.springframework.web.bind.annotation.GetMapping;
import org.springframework.web.bind.annotation.RequestMapping;
import org.springframework.web.bind.annotation.RequestParam;
import org.springframework.web.bind.annotation.RestController;

@RestController
@RequestMapping("/api/v2")
public class ApiEndpoint {

private final static Logger log = org.slf4j.LoggerFactory.getLogger(ApiEndpoint.class);
Expand All @@ -24,19 +26,19 @@ public ApiEndpoint(@NonNull final GitHubCache issueCache) {
}


@GetMapping("/api/v2/contributors")
@GetMapping("/contributors")
public Set<Contributor> getContributors() {
log.info("Getting contributors");
return issueCache.getContributors();
}

@GetMapping("/api/v2/contributors/count")
@GetMapping("/contributors/count")
public long getContributorCount() {
log.info("Getting contributors count");
return issueCache.getContributors().size();
}

@GetMapping("/api/v2/issues")
@GetMapping("/issues")
public Set<Issue> getIssues(
@RequestParam(name = "isAssigned", required = false) Boolean isAssigned,
@RequestParam(name = "isClosed", required = false) Boolean isClosed,
Expand All @@ -58,7 +60,7 @@ public Set<Issue> getIssues(
.collect(Collectors.toUnmodifiableSet());
}

@GetMapping("/api/v2/issues/count")
@GetMapping("/issues/count")
public long getIssuesCount(
@RequestParam(name = "isAssigned", required = false) Boolean isAssigned,
@RequestParam(name = "isClosed", required = false) Boolean isClosed,
Expand All @@ -68,12 +70,12 @@ public long getIssuesCount(
return getIssues(isAssigned, isClosed, filteredLabels, excludedLabels, filteredLanguages).size();
}

@GetMapping("/api/v2/repositories/stars")
@GetMapping("/repositories/stars")
public long getStarsCount() {
return issueCache.getRepositories().stream().mapToLong(repo -> repo.stars()).sum();
}

@GetMapping("/api/v2/repositories/count")
@GetMapping("/repositories/count")
public long getRepositoryCount() {
return issueCache.getRepositories().size();
}
Expand Down
Loading