Skip to content

Create generate Rrule Function #1565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
davanmur wants to merge 191 commits into
base: timeVary
Choose a base branch
from
Open

Create generate Rrule Function #1565

davanmur wants to merge 191 commits into from

Conversation

@davanmur
Copy link
Contributor

@davanmur davanmur commented Jan 6, 2026 •
edited
Loading

Description

Created a backend function that could take in information from the weekly and daily conversion patterns, and created an rrule (recurrence rule) so that conversions patterns could easily and efficiently be applied over a length of time. Integrated that function in timeVaryingPathConversion.js.

Partly Addresses #896

Type of change

  • Note merging this changes the database configuration.
  • This change requires a documentation update

Checklist

  • I have followed the OED pull request ideas
  • I have removed text in ( ) from the issue request
  • You acknowledge that every person contributing to this work has signed the OED Contributing License Agreement and each author is listed in the Description section.

Limitations

  • Based on my manual testing generateRrule.js works and segments are correctly added to edgeSegments timeVaryingPathConversion.js
  • The is an issue with memory that seems to be related to a potentially infinite while in timeVaryingPathConversion.js

minhtriet359 and others added 30 commits June 29, 2025 18:28
@minhtriet359
updated layout for create a conversion modal, changed scripts from CR…
70c4e39 
…LF to LF
@minhtriet359
changed state in create conversion modal to be compitable with new up…
de6ee87 
…dates
@minhtriet359
created an overview page for daily patterns
ffaf4a9
@minhtriet359
changed component folder name from days to daily-pattern
e72bbd7
@evan-carey
Initial UI for the weekly conversion patterns feature
e437035 
Currently read-only. Uses fake data, as the Weeks API is not yet implemented.
@minhtriet359
added UI for for daily pattern overview page and create modal
9d2d38a
@evan-carey
Merge branch 'oed-csumb-su25:development' into evan-carey/weekly-pattern
69e9433
@evan-carey
feat(weeks): add help tooltips to week views; change /weeks page link…
9f65376 
… in navbar to "Patterns - Weekly"
@evan-carey
Merge remote-tracking branch 'oed-backend/taliaBranch' into evan-care…
f4a0cc5 
…y/weeks-api
@PRINCESANCHEZ
Merge branch 'development' of https://github.com/oed-csumb-su25/OED-f…
3cae2f2 
…rontend into edit-conversions
@PRINCESANCHEZ
Add fr/es translations for Edit Conversion UI
5691a31 
Signed-off-by: PRINCESANCHEZ <princesanchez72@gmail.com>
@minhtriet359
Merge remote-tracking branch 'backend/taliaBranch' into triet_overvie…
77d031c 
…wPage

merge backend
@evan-carey
feat(weeks): complete weekly conversion patterns feature
47b3130 
* CRUD operations working with back-end
* client-side validation
* delete confirmation
* Spanish and French translations
@evan-carey
Merge remote-tracking branch 'oed-backend/taliaBranch' into evan-care…
6af16b5 
…y/weeks-api
@evan-carey
fix(weeks): create week API request fails because id is included
8835272 
Omit `id` from the default week values model
@evan-carey
revert changes to gitignore and docker-compose
dbfd046 
docker-compose should not be ignored and should not have to be altered for our time-varying conversion work
@evan-carey
fix(database): weeks table must be created before conversion_segments…
63deb77 
… table
@PRINCESANCHEZ
Merge remote-tracking branch 'talia/taliaBranch' into edit-conversions
7a6e8ed
@minhtriet359
created UI for day overview page and create day modal
6eccbe3
@minhtriet359
Merge remote-tracking branch 'backend/taliaBranch' into triet_overvie…
f13fa05 
…wPage
@minhtriet359
hooked up day to backend
70f0da5
@minhtriet359
added check to make sure days cannot have the same name
24abf08
@minhtriet359
hooked conversion create modal - need to connect pattern
da3e438
@minhtriet359
Merge remote-tracking branch 'origin/evan-carey/weeks-api' into Triet…
7fba152 
…/hook_conversion_to_backend
@minhtriet359
fix merge errors
69c2ebb
@minhtriet359
hooked up create conversion to backend
7bb4599
@minhtriet359
revert changes to git.ignore and docker-compose.yml
e9bdc07
@PRINCESANCHEZ
Merge timeVaryingConversion into edit-conversions: resolved translati…
91d3d23 
…on conflict

Signed-off-by: PRINCESANCHEZ <princesanchez72@gmail.com>
@PRINCESANCHEZ
Merge Talia’s taliaBranch into edit-conversions after resolving confl…
cdec8e0 
…icts
@evan-carey
undo formatting changes to docker-compose
92bd352
PRINCESANCHEZ and others added 30 commits September 11, 2025 14:25
@PRINCESANCHEZ
Allow editing segment start/end with neighbor auto-update and validation
c8c849a 
Signed-off-by: PRINCESANCHEZ <princesanchez72@gmail.com>
@PRINCESANCHEZ
refactor: improve datetime validation, clear errors on input, remove …
612799c 
…required attrs

Signed-off-by: PRINCESANCHEZ <princesanchez72@gmail.com>
@PRINCESANCHEZ
disable save when unchanged and add success/error notifications
bfaf3cd 
Signed-off-by: PRINCESANCHEZ <princesanchez72@gmail.com>
@PRINCESANCHEZ
Merge branch 'edit-conversions' into evan-carey/days-edit
615b227
@PRINCESANCHEZ
remove unused exports
c5ecc50 
Signed-off-by: PRINCESANCHEZ <princesanchez72@gmail.com>
@PRINCESANCHEZ
Merge branch 'edit-conversions' into evan-carey/days-edit
2da5d3f
@huss
remove edit conversion warning
576c2ae
@huss
commenting change to address PR comment
26e7e0a
@PRINCESANCHEZ
Add error handling with showErrorNotification for neighbor segment au…
b8ef6b5 
…to-adjust

Signed-off-by: PRINCESANCHEZ <princesanchez72@gmail.com>
@PRINCESANCHEZ
Update split time placeholder to use complete and move to translations
c61046b 
Signed-off-by: PRINCESANCHEZ <princesanchez72@gmail.com>
@davanmur
redo changes I accidentally undid
46df415
@davanmur
install rrule
c172ef5
@davanmur
getting data from createWeekModalComponent to generateRrule
27e7ca6
@davanmur
generate an rrule from data
8548f28
@davanmur
move generateRule to server
07ed783
@davanmur
timeVaryingPathConversion script
30a2b3b
@davanmur
update redoCik and add updateCikVaryAndViews script to package.json
821ad97
@davanmur
update createConversionArrays.js (for redoCik)
36b441d
@davanmur
remove frontend testing, add CikVary model, and fix script
bba473f
@davanmur
fixes to timeVaryPathConversion
9eb2f66
@davanmur
add sql/cik_vary sql files
286f8ed
@davanmur
update timeVaryingPathConversion
c3d6ca1
@davanmur
update generateRrule to fetch week and unique daySegments
b6b48ae
@davanmur
call generateRule in timeVaryingPathConversions and generate occurences
521c5be
@davanmur
fix generateRrule
61d84c7
@davanmur
add code to create new ConversionSegments from rrule occurences and a…
665a4df 
…dd them to edgeSegments
@davanmur
clean up comments
3c871d4
@davanmur
remove used variables from CreateWeekModalComponent
402c32a
@davanmur
delete unused import from CreateWeekModalComponent
8da7990
@davanmur
fix up generateRrule.js and timeVaryingPathConversion.js and delete g…
f496eda 
…enerateRrule.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@davanmur @minhtriet359 @evan-carey @PRINCESANCHEZ @Gomez-V @huss