Skip to content

Conversation

@Andrew-Bonner
Copy link

Description

(Please include a summary of the change and which issue is touched on. Please also include relevant motivation and context.)

Fixes #[issue]

(In general, OED likes to have at least one issue associated with each pull request. Replace [issue] with the OED GitHub issue number. In the preview you will see an issue description if you hover over that number. You can create one yourself before doing this pull request. This is where details are normally given on what is being addressed. Note you should not use the word "Fixes" if it does not completely address the issue since the issue would automatically be closed on merging the pull request. In that case use "Partly Addresses #[issue].)

Type of change

(Check the ones that apply by placing an "x" instead of the space in the [ ] so it becomes [x])

  • Note merging this changes the database configuration.
  • This change requires a documentation update

Checklist

(Note what you have done by placing an "x" instead of the space in the [ ] so it becomes [x]. It is hoped you do all of them.)

  • I have followed the OED pull request ideas
  • I have removed text in ( ) from the issue request
  • You acknowledge that every person contributing to this work has signed the OED Contributing License Agreement and each author is listed in the Description section.

Limitations

(Describe any issues that remain or work that should still be done.)

Zachary-Squires and others added 30 commits August 21, 2025 13:16
…fy sanitizer and patch XSS in success/failure responses"
up to date. package-lock.json and package.json
should match now.
Normalize all line endings to LF
Changed the installOED.sh file to generate randomized values for OED_TOKEN_SECRET and POSTGRES_PASSWORD, which are then stored in .env file. Changed docker.compose.yml to draw from the .env file if variables exist there. When in dev mode with the default values the user will be warned in the console when OED is started. Also implemented a warning for the mailing variables, if the method is set and a default remains in the rest the user will be warned in production.
This reverts commit 489cc17, reversing
changes made to f38a83e.
Remove line endings fix, will be implemented separately.
Restoring default value of OED_PRODUCTION
Zach-O-Bates and others added 29 commits December 11, 2025 01:50
Added meeting notes for the client meeting held on November 5, 2025, including agenda items and group progress updates.
Updated meeting notes with group progress and mentor suggestions.
Added meeting notes for the client meeting on November 12th, 2025.
Added meeting notes for client meeting on November 12th, 2025, detailing issues discussed and progress made.
Added each issue as a risk, with probability, impact, and solution.
Add a single instance before the tests
@huss
Copy link
Member

huss commented Feb 5, 2026

Thank you to @Andrew-Bonner for this PR. Two items:

  1. The description is not filled out per the template and the OED developer help pages.
  2. The files listed as changed include .github/workflows and the rest seem to relate to PR Centralize and Fix DOMPurify Sanitizer #1544. I don't see the new tests for route authorization. Please let me know if I am missing something here.

I'm not going to review this PR until these two items are resolved. Please let me know if anything is not clear or you need something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants