Flang doesn't compile NWTC_IO.f90#2619
Merged
andrew-platt merged 2 commits intoOpenFAST:rc-4.0.1from Jan 29, 2025
Merged
Conversation
deslaughter
approved these changes
Jan 29, 2025
Collaborator
deslaughter
left a comment
deslaughter
left a comment
There was a problem hiding this comment.
Nice, simple fix to a weird compiler bug.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ready to merge
Feature or improvement description
The ROCM Flang compiler doesn't handle character arrays of length 1 in case statements for some reason. This modifies one routine very lightly so that Flang can compile OpenFAST
Related issue, if one exists
Issue reported internally
Impacted areas of the software
Compilation with ROCM Flang compiler only.
Additional supporting information
Flang has some peculiarities.
Test results, if applicable
None affected