Updates to c-bindings #3108
Merged
Updates to c-bindings #3108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- cleanup moordyn.py to use common stuff in interface_abc - cleanup seastate.py to use common stuff in interface_abc - cleanup aerodyn_inflow.py to use common stuff in interface_abc - use interface_abc with inflowwind.py - use interface_abc with hydrodyn.py
- New external routines: - IfW_C_GetFlowFieldPointer - IfW_C_SetFlowFieldPointer - IfW_C_GetWindVel - Updated to use NWTC_C_BINDING - minor linting - add routine to clear library memory
- ADI_C_GetFlowFieldPointer - ADI_C_SetFlowFieldPointer
to set the pointer, IfW will need to be initialized with a null data set. Init doesn't allow this at the moment
This is accurate for 1st order waves, but will exagerate a bit for 2nd order
- SeaSt_C_GetDens - SeaSt_C_GetDpth - SeaSt_C_GetMSL2SWL Also improved check on valid pointer
Interfaces are not up to date for all the changes here
andrew-platt
added
Module: AeroDyn
Module: InflowWind
Module: SeaState
Co-authored-by: andrew-platt <[email protected]>
Fix get_elevMinMax function signature to match implementation
WaveField_GetMinWaveElevEstimate --> WaveField_GetMinMaxWaveElevEstimate
deslaughter
approved these changes
Jan 7, 2026
Collaborator
There was a problem hiding this comment.
I'm a little worried about the use of .encode('utf-8') in a lot of the Python code as I'm not sure how Fortran will handle it. I researched it a bit and it seemed to be compiler and OS dependent. UTF-8 is essentially ASCII if there aren't any non-ASCII characters, so that should be fine. I think we should leave it for now, but if we get bugs in the future, the solution is to change it to .encode('ascii', 'strict') which will force the user to use ASCII file paths.
Co-authored-by: Derek Slaughter <[email protected]>
Collaborator
Author
|
I agree on the |
andrew-platt
force-pushed
the
f/c-bind_updates_ADI
branch
from
b13a579 to
9463e62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready to merge
Feature or improvement description
Several improvements to the c-bindings interfaces were developed jointly with an external partner. This PR brings in updates for the following:
AeroDyn_Inflow_C_Binding
InflowWindoutside of the libraryADI_C_GetFlowFieldPointerandADI_C_GetFlowFieldPointerfor directly manipulatingFlowFieldpointerFlowFielddata (i.e. from an instance ofInflowWindoutside the c-bind library)ADI_C_InittoADI_C_PreInitHydroDyn_C_Binding
InflowWind_C_Binding
NWTC_C_Bindingerror handling and paramsDebugLeveloutputs for troubleshooting interface issuesMemClearroutine)IfW_C_GetWindVelIfW_C_GetFlowFieldPointerIfW_C_SetFlowFieldPointerSeaState
SeaSt_WaveField.f90and c-bindingsWaveField_GetMinMaxWaveElevEstimateroutine (simple sum of max/min values of 1st and second )SeaState_C_Binding.f90DebugLeveloutputs for troubleshooting interface issuesSeaSt_C_GetDensSeaSt_C_GetDpthSeaSt_C_GetMSL2SWLpyOpenFAST
OpenFASTInterfaceTypeclass ininterface_abc.pyinterface_abc.pybase class between module interfaces, but that is not addressed hereWaveTank.f90
Related issue, if one exists
Depends on #3065
Impacted areas of the software
C-binding library interfaces,
pyOpenFAST, and regression testing interfacesTest results, if applicable
No results change, but interface in
py_seastate_1is updated to match changes inseastate.py