Skip to content

add title for encrypt and trustServerCertificate#1579

Merged
mtuchi merged 3 commits intomainfrom
mssql-config
Mar 6, 2026
Merged

add title for encrypt and trustServerCertificate#1579
mtuchi merged 3 commits intomainfrom
mssql-config

Conversation

@mtuchi
Copy link
Collaborator

@mtuchi mtuchi commented Mar 5, 2026

Summary

In configuration-schema.json of mssql adaptor both encrypt and trustServerCertificate were missing title. This PR add the title and description for encrypt config. This changes should fix the missing titles in mssql credential form

AI Usage

Please disclose how you've used AI in this work (it's cool, we just want to
know!):

  • I have used Claude Code
  • I have used another model
  • I have not used AI

You can read more details in our
Responsible AI Policy

Review Checklist

Before merging, the reviewer should check the following items:

  • Does the PR do what it claims to do?
  • If this is a new adaptor, added the adaptor on marketing website ?
  • If this PR includes breaking changes, do we need to update any jobs in
    production? Is it safe to release?
  • Are there any unit tests?
  • Is there a changeset associated with this PR? Should there be? Note that
    dev only changes don't need a changeset.
  • Have you ticked a box under AI Usage?

@mtuchi
Copy link
Collaborator Author

mtuchi commented Mar 6, 2026

@josephjclark i made changes to the configuration schema, do i need to create a changeset ?

@josephjclark
Copy link
Collaborator

@mtuchi yes please - just a patch

@mtuchi
Copy link
Collaborator Author

mtuchi commented Mar 6, 2026

@mtuchi yes please - just a patch

Done ✅ @josephjclark

@josephjclark
Copy link
Collaborator

@mtuchi you can run pnpm run version, commit the changes, and then merge the PR

@mtuchi mtuchi merged commit 9a7e637 into main Mar 6, 2026
2 checks passed
@mtuchi mtuchi deleted the mssql-config branch March 6, 2026 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Closed

Development

Successfully merging this pull request may close these issues.

3 participants