Skip to content

feat: change builders map#1589

Merged
josephjclark merged 5 commits intomainfrom
feat/1588-fhir-gen
Mar 12, 2026
Merged

feat: change builders map#1589
josephjclark merged 5 commits intomainfrom
feat/1588-fhir-gen

Conversation

@hunterachieng
Copy link
Contributor

@hunterachieng hunterachieng commented Mar 11, 2026

Summary

Format type in builder function to add spaces in between and wrap in code formatter.

New output:

A profile type: one of `SzCauseOfDeath`, `SzClinicalObservation`, `SzLabResult`, `SzMannerOfDeath`, `SzVitalSigns`

Alphabetically organise generated props

Fixes #1587 , #1588

Details

Add technical details of what you've changed (and why).

AI Usage

Please disclose how you've used AI in this work (it's cool, we just want to
know!):

  • I have used Claude Code
  • I have used another model
  • I have not used AI

You can read more details in our
Responsible AI Policy

Review Checklist

Before merging, the reviewer should check the following items:

  • Does the PR do what it claims to do?
  • If this is a new adaptor, added the adaptor on marketing website ?
  • If this PR includes breaking changes, do we need to update any jobs in
    production? Is it safe to release?
  • Are there any unit tests?
  • Is there a changeset associated with this PR? Should there be? Note that
    dev only changes don't need a changeset.
  • Have you ticked a box under AI Usage?

Signed-off-by: Hunter Achieng <achienghunter@gmail.com>
@hunterachieng
Copy link
Contributor Author

@josephjclark Should I regenerate the fhir-eswatini?

Signed-off-by: Hunter Achieng <achienghunter@gmail.com>
@josephjclark
Copy link
Collaborator

@hunterachieng yes please! Then I can validate the changes

Copy link
Collaborator

@josephjclark josephjclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! Please rebuild and commit changes

No need to re-run this for other fhir adaptors

Please add a changeset

Signed-off-by: Hunter Achieng <achienghunter@gmail.com>
Signed-off-by: Hunter Achieng <achienghunter@gmail.com>
@josephjclark
Copy link
Collaborator

Thanks @hunterachieng ! I won't release just yet - I'll wait and see if your other changes come in today, and I'll release them all together this evening or tomorrow morning

@hunterachieng
Copy link
Contributor Author

@josephjclark Do I make the other changes in a branch off of this one? Just so the changes go in all at once?

Copy link
Collaborator

@josephjclark josephjclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic hunter. Nice and clean and the PR description is up to date.

I'm going to release this tonight!

@josephjclark josephjclark merged commit acfc4aa into main Mar 12, 2026
1 check failed
@josephjclark josephjclark deleted the feat/1588-fhir-gen branch March 12, 2026 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Closed

Development

Successfully merging this pull request may close these issues.

fhir-gen: in docs, list props alphabetically

2 participants