Collections integration test #1199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
I think it's just something wrong in the mocked response structure. Can't see what. Time for a break. |
Collaborator
Author
|
Ah got it - it was me all along. A collection value MUST be a string. I was adding objects using the debug API. Maybe a good idea for the mock API to throw in these case eh |
Collaborator
Author
|
Good: I'll re-test this tomorrow once the collections adaptor is released |
josephjclark
added a commit
that referenced
this pull request
Jan 4, 2026
* cli: auto-append collections adaptor * changeset * track collections on credentials * cli: execute with collections * update command aliases * make api-token/pat usage more consistent * lightning mock: add very basic collections support * changeset * Collections integration test (#1199) * attempt test * fix test * tidying * reduce minimum release age and install * fix lockfile * remove adaptor override * package lock again * more cleanup * remove another wierd local dep * package lock yet again * fix an option conflict * fix the mock * update mock to better match lightning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to create an integration test for collections
I've updated the lightning mock to use the mock collections API in the adaptor (needs pnpm link to work)
The integration tests uses a real lightning mock server, and so far as I can tell its hitting the endpoint (kinda wierd to debug). But for some reason it always returns a 404? Or an error deep in adaptor code.
I also notice that the collections adaptor verison isn't listed in the versions list. Neither is common for that matter.