This repository was archived by the owner on Oct 21, 2022. It is now read-only.
discover(...) fails, also may be irrelevant/unnecessary#54
Open
discover(...) fails, also may be irrelevant/unnecessary#54
Conversation
taylordowns2000
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function
discover(httpMethod, resourceType)seems to be doing a job of parsing this url; https://dhis2.github.io/dhis2-api-specification/spec/metadata_openapi.json and giving informations about some httpMethod (I am not even sure why that matters). I have tested it and don't really see it's relevancy. It always returns this error message (in my case):In another hand, when I see the complexity of it's code, I am wondering if one wrote all this just for something that the user can read through documentation. In fact I am confused by this function. This PR is a deletion proposal of that function as it seems to add many lines of code for something that doesn't seem very interesting. Please @taylordowns2000 lmk what you think and let's take a decision. If you have the same point than me, then please merge this.