-
Notifications
You must be signed in to change notification settings - Fork 61
Unsaved changes indicator #4289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Unsaved changes indicator #4289
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4289 +/- ##
==========================================
- Coverage 89.37% 89.32% -0.05%
==========================================
Files 425 425
Lines 19940 19941 +1
==========================================
- Hits 17821 17812 -9
- Misses 2119 2129 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
taylordowns2000
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
noting project_credential_id from our call! ping when ready to test again please :-)
taylordowns2000
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works great @doc-han . i've requested a review from @stuartc since he worked on this also before the break.
two things (not blocking for me):
- see comment on the hard-coded expected structure. is there another way?
- check out the issue (and comment) here about warning on unsaved changes... i think it would be really nice to finally tell users "hey, you're about to navigate away with unsaved stuff" and I wonder if this new function allows us to do that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
assets/js/collaborative-editor/stores/createSessionContextStore.ts
Outdated
Show resolved
Hide resolved
6019a36 to
c8d7d08
Compare

Description
This PR shows a red dot indicator on the save button when there are unsaved changes in a workflow.

Closes #3682
Validation steps
If you're seeing a red dot right upon entering a workflow, it means there already exist unsaved changes(between what's in the DB and what's on ydoc).
Additional notes for the reviewer
AI Usage
Please disclose how you've used AI in this work (it's cool, we just want to know!):
You can read more details in our Responsible AI Policy
Pre-submission checklist
:owner,:admin,:editor,:viewer)