Pad zero uncertainties in the MLE solver #177
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #177 +/- ##
==========================================
+ Coverage 95.64% 95.67% +0.03%
==========================================
Files 18 18
Lines 1263 1273 +10
==========================================
+ Hits 1208 1218 +10
Misses 55 55 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
pre-commit.ci autofix |
IAlibay
left a comment
IAlibay
left a comment
There was a problem hiding this comment.
Not 100% sure about the impact, but adding this padding should be ok?
| for i in range(N): | ||
| for j in range(N): | ||
| if i != j and df_ij[i, j] == 0.0: | ||
| df_ij[i, j] = 1e-6 |
There was a problem hiding this comment.
How about something like df_ij[df_ij == 0.0] = 1e-6?
There was a problem hiding this comment.
Yeah I wasn't sure about replacing the absolute values on the diagonal as they are currently zero and it works but I guess there is no harm.
There was a problem hiding this comment.
ah yeah that's fair! better keep the diagonals zero
There was a problem hiding this comment.
Ahh no this causes the F_matrix to change see here where each row is multipiled by some large inverse weight. I'll revert for now.
Description
Fixes #97 by padding calculated errors of exactally zero by some small amount.
Todos
Notable points that this PR has either accomplished or will accomplish.
Questions
Checklist
newsentry for new features, bug fixes, or other user facing changes.Status
Tips
Since this will create a commit, it is best to make this comment when you are finished with your work.