Conversation
|
No API break detected ✅ |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1425 +/- ##
==========================================
- Coverage 95.11% 92.24% -2.88%
==========================================
Files 165 165
Lines 12389 12389
==========================================
- Hits 11784 11428 -356
- Misses 605 961 +356
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Nothing obviously broken |
|
Thanks for testing this @mattwthompson - just a heads up, we don't actually do anything directly with Interchange here (at least for now). So as long as relevant tests pass in openmmforcefields, we're probably fine. The place where testing might be more useful is in pontibus. There we do use Interchange directly, so that might be a good canary for "will things break", especially after we finish implementing that temporary rbfe protocol. |
|
Thanks for the added context - this was definitely me just plucking one downstream package to make sure nothing major broke. Your suggestions sound good for other places to check and I'll do those in the future |
ref openforcefield/openff-interchange#1253
Checklist
newsentryDevelopers certificate of origin