-
Notifications
You must be signed in to change notification settings - Fork 2
Adding virtual site support #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #59 +/- ##
==========================================
+ Coverage 95.69% 97.12% +1.43%
==========================================
Files 17 18 +1
Lines 1369 1461 +92
==========================================
+ Hits 1310 1419 +109
+ Misses 59 42 -17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
BenchmarksTotal cost: 11,674 GPU SUs @ UCI HPC3 ResultsHere are the results for the Cl and Br benchmarks. Note that these are also uploaded as CSV files in this PR. Note: all results are in kcal/mol Cl benchmark results
Br benchmark results
AnalysisOverall the results agree very well with the Gromacs results Meghan Osato. The only cases which seem to diverge slightly (i.e. greater than 0.5 kT) is COP(=O)(C@HO)OC with an absolute error of 0.43 kcal/mol from Gromacs. However the standard deviation for three repeats on this solute is 0.63 kcal/mol, so it's likely just a sampling issue. |
TODO: