add more params to dapr pubsub subscription#58
add more params to dapr pubsub subscription#58halegreen wants to merge 1 commit intoOpenFunction:mainfrom
Conversation
|
|
| OapServer string `json:"oapServer" yaml:"oapServer"` | ||
| } | ||
|
|
||
| type PubSubRoutingRule struct { |
There was a problem hiding this comment.
Why not define the router, match, and priority directly into the input?
There was a problem hiding this comment.
Hi, I think it is more clear to group router, match, priority to the one struct PubSubRoutingRule, other than put them directly into the input
considering every prop. Uri, ComponentName, ComponentType, Metadata maybe different for different trigger,
of input in function context
type Input struct {
Uri string `json:"uri,omitempty"`
ComponentName string `json:"componentName"`
ComponentType string `json:"componentType"`
Metadata map[string]string `json:"metadata,omitempty"`
}
|
@tpiperatgod @wrongerror hi , any suggestions on this pr? |
|
See my comments in OpenFunction/OpenFunction#332 |
fixed it . please have a look. |
Please make sure this pr does not conflict with #66, they both set the |
Looks like still not fixed OpenFunction/OpenFunction#332 (comment): |
4 participants
fix issue: OpenFunction/OpenFunction#329