[FIX] correct "pixel shuffle" → "pixel unshuffle" (typo) #1210
      
        
          +322
        
        
          −150
        
        
          
        
      
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
This pull request fix the typo in the configuration and usage of the pixel shuffle operation across the InternVL codebase, renaming it to "pixel unshuffle" for clarity and consistency.
According to Issue #727, the original name "pixel shuffle" was a typo — InternVL actually performs unshuffle, consistent with the behavior of PyTorch’s PixelUnshuffle.
This update standardizes argument names, method names, and logging messages, and adds backward-compatibility support to ensure older scripts continue to work seamlessly.
Refactoring and Renaming
ps_versiontopixel_unshuffle_versionacross the entire codebase — including model configuration classes, training scripts, and shell scripts — for better clarity and alignment with the actual operation.pixel_shuffletopixel_unshuffle, and updated all internal references, logging, and warnings accordingly.Backward Compatibility and Migration
ps_versionforpixel_unshuffle_versionin all relevant training scripts’ argument classes.main()that automatically maps the old argument to the new one while issuing a deprecation warning. This ensures that existing configuration files and shell scripts will continue to work without breaking.Shell Script Updates
--pixel_unshuffle_versioninstead of--ps_version, ensuring consistent naming between scripts and Python code.Model Configuration
pixel_unshuffle_versionconsistently — both when constructing models from pretrained weights and when building new configurations from scratch.Logging and Documentation
pixel_unshuffle_versionfield.Summary
These changes collectively improve code clarity, reduce potential confusion around the operation performed, and maintain full backward compatibility for existing users and scripts.
According to the contribution manual, I should run the pre-commit linter before submission. However, the current repository is not consistently linted — running
pre-commitmodifies many unrelated files. Please review this before merging, as I’ve intentionally avoided unrelated formatting changes to keep this PR clean and focused.