Move model-specific logic out of GuardianPermission class
#246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the model-specific logic out of
geoinsight/core/rest/access_control.pyand into the model definitions. Now each model that has a rest viewset should implement afilter_queryset_by_projectsclassmethod. TheGuardianPermissionandGuardianFilterclasses leverage those classmethods to determine which objects a user has permission to interact with via the API.Datasets are an exception; their permission structure is separate from Projects, so a subclass
DatasetGuardianPermissionis implemented to specify Dataset permissions.Resolves #208.