Skip to content

Comments

update vue-maplibre-compare and fix screenshots#288

Merged
BryonLewis merged 4 commits intomasterfrom
screenshot-fix
Feb 24, 2026
Merged

update vue-maplibre-compare and fix screenshots#288
BryonLewis merged 4 commits intomasterfrom
screenshot-fix

Conversation

@BryonLewis
Copy link
Collaborator

@BryonLewis BryonLewis commented Feb 17, 2026

resolve #283

  • Updates vue-maplibre-compare so that ToggleMapCompare and MapCompare have a new field named preserveDrawingBuffer that defaults to false but can be set to true for sharing the buffer.
  • renamed the Map.vue that is no longer used to LegacyMap.vue to indicate it's legacy usage.
  • Comparison mode screenshots will only grab the Map A Canvas. This is because comparison utilizes a css clip-path which doesn't look like it is supported by html2canvas
    • A possible solution is create a function that when screenshot is taken it draws the two separate maps into a single canvas object based on the slider position and uses that as the base canvas. I need to do more testing to see if it works.
    • Decided on hiding the screenshot button when in Compare Mode

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Feb 17, 2026

Deploying geoinsight with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3e11490
Status: ✅  Deploy successful!
Preview URL: https://acc4b948.geoinsight.pages.dev
Branch Preview URL: https://screenshot-fix.geoinsight.pages.dev

View logs

@BryonLewis BryonLewis marked this pull request as ready for review February 24, 2026 20:56
@BryonLewis BryonLewis requested a review from annehaley February 24, 2026 20:56
@BryonLewis BryonLewis merged commit 5e67045 into master Feb 24, 2026
3 checks passed
@BryonLewis BryonLewis deleted the screenshot-fix branch February 24, 2026 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Screenshot Feature Broken

2 participants