Skip to content

Comments

Upgrade Python to 3.12#289

Merged
annehaley merged 2 commits intomasterfrom
upgrade-python
Feb 19, 2026
Merged

Upgrade Python to 3.12#289
annehaley merged 2 commits intomasterfrom
upgrade-python

Conversation

@annehaley
Copy link
Collaborator

No description provided.

@annehaley annehaley requested a review from brianhelba February 19, 2026 17:15
Copy link
Collaborator

@brianhelba brianhelba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and it looks like scikit-learn is indeed at 1.8.0 now.

@brianhelba
Copy link
Collaborator

The test failure looks like a legitimate existing problem that is now newly detected by Python 3.12 (TemporaryFile not getting closed).

If you can investigate and fix, that'd be ideal. However, if it's coming from a dependency outside your control (and you can't fix it by just upgrading that dependency ), then you can add a Pytest warning filter to ignore it (which I'm happy to review too, if you'd like).

@annehaley
Copy link
Collaborator Author

Yeah, I'm trying to investigate the origin of the unclosed temp file. The only places we use the tempfile library are for creating TemporaryDirectory objects scoped via a with block. I was under the impression that the with context would clean up those files neatly. I'll keep researching the cause before we decide whether to ignore the warning.

@annehaley
Copy link
Collaborator Author

It took some hunting, but I did find a spot that needed a with block. I didn't see it at first because we don't explicitly invoke the tempfile library, but there was a spot where we open an S3FileField file without closing it. Fixed in c1a5f53.

@annehaley annehaley merged commit f438d3c into master Feb 19, 2026
3 checks passed
@annehaley annehaley deleted the upgrade-python branch February 19, 2026 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants