Conversation
brianhelba
left a comment
There was a problem hiding this comment.
LGTM, and it looks like scikit-learn is indeed at 1.8.0 now.
|
The test failure looks like a legitimate existing problem that is now newly detected by Python 3.12 ( If you can investigate and fix, that'd be ideal. However, if it's coming from a dependency outside your control (and you can't fix it by just upgrading that dependency ), then you can add a Pytest warning filter to ignore it (which I'm happy to review too, if you'd like). |
|
Yeah, I'm trying to investigate the origin of the unclosed temp file. The only places we use the |
|
It took some hunting, but I did find a spot that needed a |
No description provided.