Conversation
brianhelba
reviewed
Feb 19, 2026
terraform/update_worker.sh
Outdated
Comment on lines
20
to
21
| echo "==> Adding SOURCE_VERSION to env file..." | ||
| ssh "$SSH_TARGET" 'echo "SOURCE_VERSION=$(git -C /home/ubuntu/geoinsight rev-parse HEAD)" >> /home/ubuntu/geoinsight.prod.env' |
Collaborator
There was a problem hiding this comment.
This should come after git pull, since we want to inform the application of the SHA of the the Git commit that it'll actually be running after this update.
This variable is ultimately used to feed metadata of Sentry errors.
Collaborator
Author
There was a problem hiding this comment.
Good point. Switched the order in 7bbbc1b
brianhelba
requested changes
Feb 19, 2026
Collaborator
brianhelba
left a comment
brianhelba
left a comment
There was a problem hiding this comment.
1 essential change, but otherwise LGTM after the lines are switched.
brianhelba
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.