[#60] Publish a stable JPMS automatic module name - #119
Conversation
|
I have no clue what you mean by:
In my PR, it's not broken! It just doesn't create a module descriptor on the Java 8 build, so the Java 9+ build would need to be shipped. This PR doesn't create a proper module descriptor and doesn't add a test whether module loading actually works. An automatic module name will gain you nothing, really (except you can rename the jar file locally, which no one ever should do). So, still no jlink, modular distribution for jreleaser, etc. It's not wrong or bad to do it this way, it just doesn't solve the majority of the problems.
... I hope you just mean "not rebased"? |
|
@bmarwell I haven't reviewed this draft yet. The plan was to produce a minimal solutions to a problems that has been open for 3+ years. I couldn't say that anything you have done is wrong, though it's more involved, possibly a more comprehensive solution. |
|
@bmarwell The unmergable comment was due to a restricted main |
39df436 to
322d06c
Compare
831a69c to
322d06c
Compare
What changed
Automatic-Module-Name: net.openhft.hashingin the packaged bundle.verify.Why
This is Stage 1 of issue #60. It establishes the permanent consumer-facing module name with minimal compatibility risk while retaining the Java 8 release build. The same name is used by the explicit descriptor proposed in #107, so consumers will not need to change their
requires net.openhft.hashingdeclaration later.This PR complements #107; it is not a replacement for that contribution.
Scope and limitations
This stage provides:
It does not yet provide:
module-info.class;requires jdk.unsupported;jlinksupport;Those belong to the repository-owned continuation of #107 and the final hardening stage.
Validation
mvn -B clean verify— 14,901 unit tests, 12 skips; packaged-JAR integration test 1/1.net.openhft.hashing.mvn -o -B clean verify— both configured unit-test executions and packaged-JAR integration test passed.git diff --checkpassed.The legacy GitHub workflow currently fails before checkout because it uses retired
actions/cache@v1. Its separate workflow/Sonar maintenance is intentionally outside this PR.Tracking
Part of #60.
Stage 1 of the JPMS migration.