tui: add tab navigation hint to footers (#512)#581
tui: add tab navigation hint to footers (#512)#581ixchio wants to merge 7 commits intoOpenHands:mainfrom
Conversation
enyst
left a comment
There was a problem hiding this comment.
Hey @ixchio , thank you for the PR!
It seems, from the snapshot differences, that the Save button is not in the center anymore? And the footer text is almost "cut off" on top, it seems - could you maybe look into what happened there?
Thanks for pointing that out! I didn't notice the layout shift in the snapshots. I'll take a look at the Save button alignment and the footer clipping issue and push a fix shortly. |
The Footer widget was incorrectly placed inside the settings_container, causing layout issues where: - The Save button was no longer centered - The footer text appeared 'cut off' inside the modal Moving the Footer outside the container ensures it renders at the ModalScreen level, displaying properly at the bottom of the screen. Co-authored-by: openhands <openhands@all-hands.dev>
Fix Applied@enyst Thank you for the review feedback! I've identified and fixed the layout issue. ProblemThe
SolutionMoved the Changes Made
EvidenceThe snapshots now show:
Commit: 052cbc2 |
|
Hey @enyst just checking in on this one! I've addressed all the layout feedback (Footer moved outside the container, snapshots updated). Been open for 2 weeks now, would love to get this across the finish line. |
Description
Fixes #512.
As per the user feedback, navigating fields inside the CLI modals and screens exclusively with the
Tabkey was atypical and unintuitive, leaving users to think the application was broken.To improve discoverability:
Tabkey binding globally to the main Application viaOpenHandsApp.SettingsScreenmodal to explicitly include aFooterand added theTabkey to its bindings list as well.Evidence of Changes
make lintand the changes are formatting-compliant.make testfor regression tests.make test-snapshots --snapshot-updateto capture the new footer text logic showing "Tab Navigate".I hope this helps new users get to their setup much quicker! Let me know if there's anything else you need.