Skip to content

tui: add tab navigation hint to footers (#512)#581

Open
ixchio wants to merge 7 commits intoOpenHands:mainfrom
ixchio:fix-tab-navigation-issue-512
Open

tui: add tab navigation hint to footers (#512)#581
ixchio wants to merge 7 commits intoOpenHands:mainfrom
ixchio:fix-tab-navigation-issue-512

Conversation

@ixchio
Copy link

@ixchio ixchio commented Mar 8, 2026

Description

Fixes #512.

As per the user feedback, navigating fields inside the CLI modals and screens exclusively with the Tab key was atypical and unintuitive, leaving users to think the application was broken.

To improve discoverability:

  1. Added the Tab key binding globally to the main Application via OpenHandsApp.
  2. Modified the SettingsScreen modal to explicitly include a Footer and added the Tab key to its bindings list as well.

Evidence of Changes

  • Ran make lint and the changes are formatting-compliant.
  • Ran make test for regression tests.
  • Re-generated visual SVGs via make test-snapshots --snapshot-update to capture the new footer text logic showing "Tab Navigate".

I hope this helps new users get to their setup much quicker! Let me know if there's anything else you need.

Copy link
Author

@ixchio ixchio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yo

Copy link
Collaborator

@enyst enyst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ixchio , thank you for the PR!

It seems, from the snapshot differences, that the Save button is not in the center anymore? And the footer text is almost "cut off" on top, it seems - could you maybe look into what happened there?

Image

@ixchio
Copy link
Author

ixchio commented Mar 14, 2026

Hey @ixchio , thank you for the PR!

It seems, from the snapshot differences, that the Save button is not in the center anymore? And the footer text is almost "cut off" on top, it seems - could you maybe look into what happened there?

Thanks for pointing that out! I didn't notice the layout shift in the snapshots. I'll take a look at the Save button alignment and the footer clipping issue and push a fix shortly.

The Footer widget was incorrectly placed inside the settings_container,
causing layout issues where:
- The Save button was no longer centered
- The footer text appeared 'cut off' inside the modal

Moving the Footer outside the container ensures it renders at the
ModalScreen level, displaying properly at the bottom of the screen.

Co-authored-by: openhands <openhands@all-hands.dev>
Copy link
Author

ixchio commented Mar 14, 2026

Fix Applied

@enyst Thank you for the review feedback! I've identified and fixed the layout issue.

Problem

The Footer() widget was incorrectly placed inside the settings_container Container, which caused:

  1. The Save button to shift from center alignment
  2. The footer text to appear "cut off" within the modal content area

Solution

Moved the Footer() yield statement outside the with Container(id="settings_container"): block, so it now renders at the ModalScreen level instead of inside the modal content.

Changes Made

  • openhands_cli/tui/modals/settings/settings_screen.py: Moved yield Footer() outside the container context
  • Updated snapshots to reflect the corrected layout

Evidence

The snapshots now show:

  • Save and Cancel buttons properly centered in the modal
  • Footer with "tab Navigate esc Cancel" correctly positioned at the bottom of the screen

Commit: 052cbc2

@ixchio ixchio requested a review from enyst March 14, 2026 07:07
@ixchio
Copy link
Author

ixchio commented Mar 25, 2026

Hey @enyst just checking in on this one! I've addressed all the layout feedback (Footer moved outside the container, snapshots updated). Been open for 2 weeks now, would love to get this across the finish line.
Does the latest look good to you? 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CLI] Using "Tab" to navigate in CLI is atypical

3 participants