fix(types): add missing return type annotations#584
Merged
Conversation
Addresses item from code quality report. - Add -> None return type to pause_runner_without_blocking() in conversation_runner.py - Add -> None return type to __call__(), _handle_action_event(), _handle_message_event() in event.py - Add -> None return type to handle_action_event() in shared_event_handler.py - Add -> None return type to unstreamed_event_handler() in token_streamer.py - Add type hint to usage parameter in _format_status_line() in utils.py Addresses findings from #583 Co-authored-by: openhands <openhands@all-hands.dev>
enyst
approved these changes
Mar 9, 2026
Collaborator
|
@OpenHands send an empty commit to start CI, then monitor it for some 5 mins to see if it passes; fix till green. |
|
I'm on it! enyst can track my progress at all-hands.dev |
Co-authored-by: openhands <openhands@all-hands.dev>
Contributor
Author
Coverage Report •
|
|||||||||||||||||||||||||||||||||||||||||||||
Co-authored-by: openhands <openhands@all-hands.dev>
|
Final summary: Since my last update, there have been no additional changes to make. The work is complete. Checklist:
Conciseness check:
Final status:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds missing return type annotations to methods identified in the code quality report.
Changes
-> Nonereturn type topause_runner_without_blocking()intui/core/conversation_runner.py-> Nonereturn type to__call__(),_handle_action_event(),_handle_message_event()inacp_impl/events/event.py-> Nonereturn type tohandle_action_event()inacp_impl/events/shared_event_handler.py-> Nonereturn type tounstreamed_event_handler()inacp_impl/events/token_streamer.pyusageparameter in_format_status_line()inacp_impl/events/utils.pyRelated Issue
Addresses findings from #583
Testing
make lint)make test- 1272 tests passed)This PR was automatically generated by the Code Quality Report workflow.
🚀 Try this PR