Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ classifiers = [
"Programming Language :: Python :: 3.13",
]
dependencies = [
"openhands-sdk==1.11.5",
"openhands-tools==1.11.5",
"openhands-sdk==1.13.1",
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟠 Important - Major Version Bump Risk: These SDK updates pull in major version bumps of transitive dependencies:

  • cyclopts: 3.23.1 → 4.9.0 (major version change)
  • fastmcp: 2.12.2 → 3.1.0 (major version change)
  • mcp: 1.13.1 → 1.26.0 (significant jump)

Major version changes can introduce breaking API changes. Have you verified that:

  1. All tests pass (make test, make test-snapshots, make test-binary)?
  2. The CLI still runs without errors (uv run openhands --help)?
  3. A basic conversation flow works end-to-end?

Also notable: This bump adds 15+ new transitive dependencies (redis, fakeredis, keyring, lupa, beartype, etc.) and removes the openapi-core validation stack. This is a significant architectural change in the SDK, not just a patch-level bump.

"openhands-tools==1.13.1",
Comment on lines 16 to +20
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟠 Important - Missing Evidence Section:

The PR description should include an Evidence section proving this upgrade works. For a dependency bump this significant, include:

## Evidence

### Test Results
- `make test` - ✅ All unit/integration tests pass
- `make test-snapshots` - ✅ No UI regressions  
- `make test-binary` - ✅ PyInstaller build works

### Smoke Test
```bash
$ uv run openhands --help
[output showing CLI works]

$ uv run openhands
[screenshot or description of successful TUI startup]

Without evidence, we're trusting that an automated bump of packages with major version changes doesn't break anything. That's not pragmatic - it's gambling.

"openhands-workspace==1.11.1",
"prompt-toolkit>=3",
"rich<14.3.0",
Expand Down
Loading
Loading