feat: allow raw automations to start disabled - #387
Open
XiaoFeiCode wants to merge 1 commit into
Open
Conversation
Contributor
|
👋 This PR needs a couple of things fixed before OpenHands can review it:
Push an update once this is addressed and this check re-runs automatically. This is an automated check - no AI was used to generate this comment. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
OpenHands/OpenHands#16567 adds a controlled test-run gate to automation creation. Raw bundle automations must be persisted as disabled before their first manual dispatch; creating them enabled and disabling them in a follow-up request leaves a race where a schedule or event can trigger untested code.
Summary
enabledfield toCreateAutomationRequest, defaulting totruefor backward compatibilityAutomationRelated issue
Supports OpenHands/OpenHands#16567.
Validation
uvx ruff check openhands/automation/router.py openhands/automation/schemas.py tests/test_router.pyuvx ruff format --check openhands/automation/router.py openhands/automation/schemas.py tests/test_router.pypython -m py_compile openhands/automation/router.py openhands/automation/schemas.py tests/test_router.pygit diff --checkThe targeted pytest could not be executed on Windows because
litellm==1.93.0publishes Linux wheels only and its source build requires an MSVC linker that is not installed. The test is included for Linux CI.