fix: pin SDK to known-good 500-image build SHA#506
Closed
simonrosenberg wants to merge 1 commit intomainfrom
Closed
fix: pin SDK to known-good 500-image build SHA#506simonrosenberg wants to merge 1 commit intomainfrom
simonrosenberg wants to merge 1 commit intomainfrom
Conversation
Pin the vendored software-agent-sdk submodule to 30819566b56b592cedcd1dc0d503a454f8ca6668, which is the last SDK commit verified by successful end-to-end 500-image SWE-Bench and SWT-Bench builds. Co-authored-by: openhands <openhands@all-hands.dev>
Collaborator
all-hands-bot
left a comment
There was a problem hiding this comment.
Approach is correct (rollback on regression), but the PR description has unfilled template placeholders where evidence should be. See detailed feedback below.
🟡 Verdict: The submodule rollback itself is pragmatically sound, but the PR description needs completion before merge. The claims about "known-good SHA" and workflow run links are blank/missing - fill these in to substantiate the rollback justification.
Collaborator
Author
|
Pinning the sdk to an old version is not an acceptable fix since it won't allow to evaluate new sdk versions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
software-agent-sdksubmodule to30819566b56b592cedcd1dc0d503a454f8ca6668Why this fix
Issue #504 tracks the 500-image build regression that followed the SDK bump bundled into #456. Recent repo history shows:
22967520137on SDK30819566b56b592cedcd1dc0d503a454f8ca666822967516108on the same SDK SHAThis branch pins
benchmarksback to the last SDK SHA already proven to complete both workflows end to end.Validation
make builduv run pytest tests/test_llm_config.py2298517317622985173172Fixes #504