fix: update SDK submodule with portable Python bundling for commit0#613
fix: update SDK submodule with portable Python bundling for commit0#613simonrosenberg wants to merge 1 commit intomainfrom
Conversation
Update SDK submodule to include the Python runtime bundling fix (OpenHands/software-agent-sdk#2678). The agent-server Dockerfile now bundles Python into /agent-server/.python/, making the venv portable across base images. This fixes commit0 evaluations where all runtime pods were stuck in pending because the agent-server container couldn't start — the venv symlinked to /usr/local/bin/python3 which doesn't exist in commit0's Ubuntu 22.04 base images. Fixes #607 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
all-hands-bot
left a comment
There was a problem hiding this comment.
🟡 Acceptable - Pragmatic fix for a real problem, but with execution issues that need addressing.
[CRITICAL ISSUES]
Dependency on Unmerged Code: You're updating the submodule to commit 45510235 from SDK PR #2678, which is still OPEN and not merged. This creates fragile state - if that PR changes or never merges, this becomes an orphaned dependency. Either:
- Wait for #2678 to merge, then update, OR
- If urgency demands it, clearly document this is a temporary pin and commit to updating once #2678 lands
Branch Severely Out of Date: This branch is 25 commits behind main. The merge will be a mess. Rebase on current main before proceeding.
Incomplete Testing: Your test plan shows [ ] for "Rebuild commit0 eval images and run evaluation end-to-end" - the ONE test that actually proves this fixes issue #607. Until that checkbox is ticked, you haven't proven the fix works in the real scenario.
[IMPROVEMENT OPPORTUNITIES]
Missing Evidence Section: The PR description mentions local testing but provides no concrete runtime proof. Add an Evidence section showing:
- The exact command(s) used to build the commit0 image with the new SDK
- The command to run a commit0 evaluation
- Output proving the pods start successfully (not stuck in pending)
- Python version verification in the running container
Tests alone don't count - show the real end-to-end behavior.
VERDICT
❌ Needs rework: Don't merge until:
- Branch is rebased on current main
- End-to-end evaluation is complete (not just image build)
- Evidence is provided in PR description
- Decision made on SDK PR #2678 dependency
KEY INSIGHT
The technical solution (bundling Python runtime for portability) is solid pragmatism. The problem is real, the fix is reasonable. But you're trying to merge an outdated branch that depends on unmerged upstream code, and you haven't proven the fix actually works end-to-end. Finish the job, then ship it.
Summary
Problem
Since SDK v1.15.0 (Mar 26), the agent-server Dockerfile builds a venv with symlinks to
/usr/local/bin/python3(from the builder'spython:3.13-bookworm). Commit0 base images are Ubuntu 22.04 with Python at/usr/bin/python3, so the container fails to start:Fix
The SDK fix bundles the Python runtime (interpreter + stdlib + libpython) into
/agent-server/.python/and repoints venv symlinks at it, making the image portable across any base image.Test plan
docker.io/wentingzhao/tinydb:v0base — starts successfullyPython: /agent-server/.venv/bin/python 3.13.12Depends on: OpenHands/software-agent-sdk#2678
Fixes #607
🤖 Generated with Claude Code