-
Notifications
You must be signed in to change notification settings - Fork 0
Replace dates with version numbers in directory names #210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change updates the directory naming convention from YYYYMM_model_name
to {version}_{model_name} format (e.g., v1.8.3_claude-4.5-sonnet).
Changes:
- Renamed all result directories to use version numbers instead of dates
- Updated directory_name field in all metadata.json files
- Updated README.md documentation with new naming convention
- Added validation for directory_name format in validate_schema.py
- Updated tests to use new naming convention
- Added tests for directory naming validation
Fixes #209
Co-authored-by: openhands <[email protected]>
📊 Progress Report✅ Schema ValidationThis report measures progress towards the 3D array goal (benchmarks × models × metrics) as described in #2. |
This workflow runs on:
- Push to main (when results/ directory changes)
- Pull requests to main (when results/ directory changes)
It validates:
- Directory names follow {version}_{model_name} format
- metadata.json contains valid semantic version
- directory_name matches agent_version and model fields
Co-authored-by: openhands <[email protected]>
📊 Progress Report✅ Schema ValidationThis report measures progress towards the 3D array goal (benchmarks × models × metrics) as described in #2. |
This reverts commit 11011d4.
📊 Progress Report✅ Schema ValidationThis report measures progress towards the 3D array goal (benchmarks × models × metrics) as described in #2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the directory naming convention from
YYYYMM_model_nameto{version}_{model_name}format (e.g.,v1.8.3_claude-4.5-sonnet).Fixes #209
Changes
Directory Renaming
202511_claude-4.5-sonnet) to version-based format (e.g.,v1.8.3_claude-4.5-sonnet)directory_namefield in allmetadata.jsonfiles to match the new directory namesDocumentation
README.mdwith the new naming convention:Validation
directory_nameformat invalidate_schema.py:{version}_{model_name}patternagent_versionandmodelfieldsTests
test_valid_directory_name_format: Validates correct format passestest_invalid_directory_name_date_format: Validates old date format failstest_invalid_directory_name_mismatch: Validates mismatched version/model failsTesting
All 36 tests pass:
Schema validation passes for all result directories:
@neubig can click here to continue refining the PR