fix: require litellm provider registry for unverified provider parsing

Co-authored-by: openhands <openhands@all-hands.dev>

Author: enyst

openhands-sdk/openhands/sdk/llm/utils/unverified_models.py

@@ -89,10 +89,7 @@ def _split_is_actually_version(split: list[str]) -> bool:
 
 
 def _get_litellm_provider_names() -> set[str]:
-    try:
-        provider_list = litellm.provider_list
-    except AttributeError:
-        return set()
+    provider_list = litellm.provider_list
 
     result: set[str] = set()
 
@@ -111,10 +108,6 @@ def _get_litellm_provider_names() -> set[str]:
 _LITELLM_PROVIDER_NAMES = _get_litellm_provider_names()
 
 
-def _has_provider_registry() -> bool:
-    return bool(_LITELLM_PROVIDER_NAMES)
-
-
 def _extract_model_and_provider(model: str) -> tuple[str, str, str]:
     """Extract provider and model information from a model identifier.
 
@@ -151,10 +144,7 @@ def _extract_model_and_provider(model: str) -> tuple[str, str, str]:
     provider = split[0]
     model_id = separator.join(split[1:])
 
-    # If we have a provider registry, only accept known LiteLLM providers.
-    # If not, fall back to the historical behavior to avoid dropping all
-    # provider groupings in older LiteLLM versions.
-    if _has_provider_registry() and provider not in _LITELLM_PROVIDER_NAMES:
+    if provider not in _LITELLM_PROVIDER_NAMES:
         return "", model, ""
 
     return provider, model_id, separator

tests/sdk/llm/test_model_list.py

@@ -44,42 +44,6 @@ def test_organize_models_and_providers():
         assert "1024-x-1024/gpt-image-1.5" in result["other"]
 
 
-def test_unverified_models_fallback_when_no_provider_list():
-    models = [
-        "openai/gpt-4o",  # treated as unverified (provider validation disabled)
-        "anthropic/claude-sonnet-4-20250514",  # treated as unverified
-        "o3",  # openhands model -> excluded
-        "custom-provider/custom-model",
-        "us.anthropic.claude-3-5-sonnet-20241022-v2:0",
-        "1024-x-1024/gpt-image-1.5",
-    ]
-
-    with (
-        patch(
-            "openhands.sdk.llm.utils.unverified_models.get_supported_llm_models",
-            return_value=models,
-        ),
-        patch(
-            "openhands.sdk.llm.utils.unverified_models._LITELLM_PROVIDER_NAMES",
-            set(),
-        ),
-    ):
-        result = get_unverified_models()
-
-    # Without provider validation, openai/anthropic entries are treated as
-    # verified and therefore are excluded from the unverified mapping.
-    assert "openai" not in result
-    assert "anthropic" not in result
-
-    # When LiteLLM doesn't expose a provider registry, we keep historical behavior
-    # (split on '/' or '.') rather than bucketing everything under "other".
-    assert result == {
-        "custom-provider": ["custom-model"],
-        "us": ["anthropic.claude-3-5-sonnet-20241022-v2:0"],
-        "1024-x-1024": ["gpt-image-1.5"],
-    }
-
-
 def test_list_bedrock_models_without_boto3(monkeypatch):
     """Should warn and return empty list if boto3 is missing."""
     # Pretend boto3 is not installed