Skip to content

fix(tools): merge subagents metrics (TaskToolSet)#2222

Merged
VascoSch92 merged 13 commits intomainfrom
vasco/issue-2180-task-tool
Feb 27, 2026
Merged

fix(tools): merge subagents metrics (TaskToolSet)#2222
VascoSch92 merged 13 commits intomainfrom
vasco/issue-2180-task-tool

Conversation

@VascoSch92
Copy link
Copy Markdown
Contributor

@VascoSch92 VascoSch92 commented Feb 26, 2026

Summary

(ref #2180)

Same problem as in #2221

Same solution.

Checklist

  • If the PR is changing/adding functionality, are there tests to reflect this?
  • If there is an example, have you run the example to make sure that it works?
  • If there are instructions on how to run the code, have you followed the instructions and made sure that it works?
  • If the feature is significant enough to require documentation, is there a PR open on the OpenHands/docs repository with the same branch name?
  • Is the github CI passing?

Agent Server images for this PR

GHCR package: https://github.com/OpenHands/agent-sdk/pkgs/container/agent-server

Variants & Base Images

Variant Architectures Base Image Docs / Tags
java amd64, arm64 eclipse-temurin:17-jdk Link
python amd64, arm64 nikolaik/python-nodejs:python3.12-nodejs22 Link
golang amd64, arm64 golang:1.21-bookworm Link

Pull (multi-arch manifest)

# Each variant is a multi-arch manifest supporting both amd64 and arm64
docker pull ghcr.io/openhands/agent-server:cf83b49-python

Run

docker run -it --rm \
  -p 8000:8000 \
  --name agent-server-cf83b49-python \
  ghcr.io/openhands/agent-server:cf83b49-python

All tags pushed for this build

ghcr.io/openhands/agent-server:cf83b49-golang-amd64
ghcr.io/openhands/agent-server:cf83b49-golang_tag_1.21-bookworm-amd64
ghcr.io/openhands/agent-server:cf83b49-golang-arm64
ghcr.io/openhands/agent-server:cf83b49-golang_tag_1.21-bookworm-arm64
ghcr.io/openhands/agent-server:cf83b49-java-amd64
ghcr.io/openhands/agent-server:cf83b49-eclipse-temurin_tag_17-jdk-amd64
ghcr.io/openhands/agent-server:cf83b49-java-arm64
ghcr.io/openhands/agent-server:cf83b49-eclipse-temurin_tag_17-jdk-arm64
ghcr.io/openhands/agent-server:cf83b49-python-amd64
ghcr.io/openhands/agent-server:cf83b49-nikolaik_s_python-nodejs_tag_python3.12-nodejs22-amd64
ghcr.io/openhands/agent-server:cf83b49-python-arm64
ghcr.io/openhands/agent-server:cf83b49-nikolaik_s_python-nodejs_tag_python3.12-nodejs22-arm64
ghcr.io/openhands/agent-server:cf83b49-golang
ghcr.io/openhands/agent-server:cf83b49-java
ghcr.io/openhands/agent-server:cf83b49-python

About Multi-Architecture Support

  • Each variant tag (e.g., cf83b49-python) is a multi-arch manifest supporting both amd64 and arm64
  • Docker automatically pulls the correct architecture for your platform
  • Individual architecture tags (e.g., cf83b49-python-amd64) are also available if needed

VascoSch92 and others added 7 commits February 25, 2026 17:08
- Simplify builtin agent tests (no mocks, focus on registry contracts)

- Extend delegation example to demonstrate built-in explore/bash agents

Co-authored-by: openhands <openhands@all-hands.dev>
Copy link
Copy Markdown
Collaborator

@all-hands-bot all-hands-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 LGTM - Clean fix for sub-agent metrics isolation. The solution is simple: reset metrics on sub-agent creation, merge back before eviction. Tests verify real behavior without over-mocking. No issues found.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 26, 2026

Coverage

Coverage Report •
FileStmtsMissCoverMissing
openhands-tools/openhands/tools/task
   manager.py1217736%64–66, 70–72, 79, 81, 84, 87–88, 92–93, 97, 101–104, 107–109, 111, 135–136, 138–139, 144, 150, 157–158, 163–165, 173, 180, 189–191, 199, 205, 215–216, 218–221, 223, 239–240, 242, 244–245, 248, 250, 254–255, 257–260, 262–270, 272–273, 275, 282–283, 289–290, 292
TOTAL19103967649% 

Copy link
Copy Markdown
Collaborator

@enyst enyst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd take this in, thank you, I just left a tiny comment for further thinking

@VascoSch92 VascoSch92 changed the base branch from vasco/issue-2051 to main February 27, 2026 12:04
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 27, 2026

API breakage checks (Griffe)

Result: Passed

Action log

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 27, 2026

Agent server REST API breakage checks (OpenAPI)

Result: Passed

Action log

@VascoSch92 VascoSch92 merged commit 731809d into main Feb 27, 2026
21 checks passed
@VascoSch92 VascoSch92 deleted the vasco/issue-2180-task-tool branch February 27, 2026 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants