fix(tools): merge subagents metrics (TaskToolSet)#2222
Merged
VascoSch92 merged 13 commits intomainfrom Feb 27, 2026
Merged
Conversation
- Simplify builtin agent tests (no mocks, focus on registry contracts) - Extend delegation example to demonstrate built-in explore/bash agents Co-authored-by: openhands <openhands@all-hands.dev>
all-hands-bot
approved these changes
Feb 26, 2026
Collaborator
all-hands-bot
left a comment
There was a problem hiding this comment.
🟢 LGTM - Clean fix for sub-agent metrics isolation. The solution is simple: reset metrics on sub-agent creation, merge back before eviction. Tests verify real behavior without over-mocking. No issues found.
Contributor
Coverage Report •
|
||||||||||||||||||||
enyst
reviewed
Feb 26, 2026
enyst
approved these changes
Feb 26, 2026
Collaborator
enyst
left a comment
There was a problem hiding this comment.
I'd take this in, thank you, I just left a tiny comment for further thinking
Contributor
API breakage checks (Griffe)Result: Passed |
Contributor
Agent server REST API breakage checks (OpenAPI)Result: Passed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
(ref #2180)
Same problem as in #2221
Same solution.
Checklist
Agent Server images for this PR
• GHCR package: https://github.com/OpenHands/agent-sdk/pkgs/container/agent-server
Variants & Base Images
eclipse-temurin:17-jdknikolaik/python-nodejs:python3.12-nodejs22golang:1.21-bookwormPull (multi-arch manifest)
# Each variant is a multi-arch manifest supporting both amd64 and arm64 docker pull ghcr.io/openhands/agent-server:cf83b49-pythonRun
All tags pushed for this build
About Multi-Architecture Support
cf83b49-python) is a multi-arch manifest supporting both amd64 and arm64cf83b49-python-amd64) are also available if needed