Skip to content

fix(terminal): avoid importing Unix-only modules on Windows #2250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
neubig wants to merge 2 commits into from
Closed

fix(terminal): avoid importing Unix-only modules on Windows #2250

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4803ccc
fix(terminal): avoid importing Unix-only modules on Windows
openhands-agent Mar 1, 2026
5458a07
chore: fix pre-commit lint issue (add blank line)
openhands-agent Mar 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 27 additions & 13 deletions openhands-tools/openhands/tools/terminal/terminal/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,24 +1,38 @@
import sys

from openhands.tools.terminal.terminal.factory import create_terminal_session
from openhands.tools.terminal.terminal.interface import (
TerminalInterface,
TerminalSessionBase,
)
from openhands.tools.terminal.terminal.subprocess_terminal import (
SubprocessTerminal,
)
from openhands.tools.terminal.terminal.terminal_session import (
TerminalCommandStatus,
TerminalSession,
)
from openhands.tools.terminal.terminal.tmux_terminal import TmuxTerminal


__all__ = [
"TerminalInterface",
"TerminalSessionBase",
"TmuxTerminal",
"SubprocessTerminal",
"TerminalSession",
"TerminalCommandStatus",
"create_terminal_session",
]
# SubprocessTerminal and TmuxTerminal use Unix-only modules (fcntl, pty)
# Only import them on Unix-like systems
if sys.platform != "win32":
from openhands.tools.terminal.terminal.subprocess_terminal import (
SubprocessTerminal,
)
from openhands.tools.terminal.terminal.tmux_terminal import TmuxTerminal

__all__ = [
"TerminalInterface",
"TerminalSessionBase",
"TmuxTerminal",
"SubprocessTerminal",
"TerminalSession",
"TerminalCommandStatus",
"create_terminal_session",
]
else:
__all__ = [
"TerminalInterface",
"TerminalSessionBase",
"TerminalSession",
"TerminalCommandStatus",
"create_terminal_session",
]
Loading