PR review agent: make eval-risk approval policy repo-specific#2254
Merged
PR review agent: make eval-risk approval policy repo-specific#2254
Conversation
Co-authored-by: openhands <openhands@all-hands.dev>
Contributor
API breakage checks (Griffe)Result: Failed Log excerpt (first 1000 characters) |
Contributor
Agent server REST API breakage checks (OpenAPI)Result: Passed |
all-hands-bot
approved these changes
Mar 1, 2026
Collaborator
all-hands-bot
left a comment
There was a problem hiding this comment.
LGTM! ✅
Clean refactoring that correctly separates repo-specific policy from generic example template. The eval-risk approval policy now lives in the right place (.agents/skills/custom-codereview-guide.md) while keeping the example prompt generic for downstream repos.
Minor improvements in clarity ("plausibly affect", "COMMENT review") are nice touches. No issues found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the eval/benchmark-risk approval policy out of the global PR review prompt (used by the pr-review GitHub Action across repos) and into this repository's code-review skill (.agents/skills/custom-codereview-guide.md).
This keeps the action prompt generic for downstream repos while still enforcing the policy for OpenHands/software-agent-sdk.
Agent Server images for this PR
• GHCR package: https://github.com/OpenHands/agent-sdk/pkgs/container/agent-server
Variants & Base Images
eclipse-temurin:17-jdknikolaik/python-nodejs:python3.12-nodejs22golang:1.21-bookwormPull (multi-arch manifest)
# Each variant is a multi-arch manifest supporting both amd64 and arm64 docker pull ghcr.io/openhands/agent-server:540a868-pythonRun
All tags pushed for this build
About Multi-Architecture Support
540a868-python) is a multi-arch manifest supporting both amd64 and arm64540a868-python-amd64) are also available if needed