Add gpt-5-3-codex model to resolve_model_config.py#2292
Merged
juanmichelini merged 2 commits intomainfrom Mar 3, 2026
Merged
Conversation
- Added gpt-5-3-codex model configuration to MODELS dictionary - Added test_gpt_5_3_codex_config() test function - Added test_model alias for backward compatibility with tests Co-authored-by: openhands <openhands@all-hands.dev>
Contributor
API breakage checks (Griffe)Result: Failed Log excerpt (first 1000 characters) |
Contributor
Agent server REST API breakage checks (OpenAPI)Result: Passed |
all-hands-bot
approved these changes
Mar 3, 2026
Collaborator
all-hands-bot
left a comment
There was a problem hiding this comment.
🟢 Good taste - Clean addition following existing patterns.
Assessment:
- Model config follows the exact pattern of
gpt-5.2-codex- no surprises - The
test_model = check_modelalias is correctly preserving backward compatibility with existing test imports (used inTestTestModelclass) - Test coverage mirrors other model tests - sufficient for a config entry
Verdict: ✅ LGTM - straightforward config addition with proper backward compatibility handling.
Contributor
🧪 Integration Tests ResultsOverall Success Rate: 0.0% 📊 Summary
📋 Detailed Resultslitellm_proxy_gpt_5_3_codex
Skipped Tests:
Failed Tests:
|
zparnold
added a commit
to zparnold/software-agent-sdk
that referenced
this pull request
Mar 5, 2026
Cherry-pick from upstream 10ccfad
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the
gpt-5-3-codexmodel toresolve_model_config.pyfor evaluation purposes.This PR follows the guidelines in
.github/run-eval/ADDINGMODEL.mdby:test_modelalias for backward compatibility instead of modifying existing test importsChanges
gpt-5-3-codexto the MODELS dictionary inresolve_model_config.pytest_gpt_5_3_codex_config()test function intests/github_workflows/test_resolve_model_config.pytest_model = check_modelalias for backward compatibility with existing test importsConfiguration
gpt-5-3-codexlitellm_proxy/gpt-5-3-codexWhy This Approach?
The existing branch
openhands/add-gpt-5-3-codexviolated the ADDINGMODEL.md guidelines by:test_modeltocheck_modelin imports (explicitly forbidden in line 197)TestTestModeltoTestCheckModel(modifying existing code)This PR takes a cleaner approach by:
test_modelalias to maintain backward compatibilityAdditional Notes
gpt-5.3-codexis already included in the GPT-5 codex variant patterns inmodel_prompt_spec.py(line 2)"gpt-5"inmodel_features.pyalready covers this model, so no explicit additions neededTest Results
Checklist
test_gpt_5_3_codex_config()resolve_model_config.pyFixes #2289
Agent Server images for this PR
• GHCR package: https://github.com/OpenHands/agent-sdk/pkgs/container/agent-server
Variants & Base Images
eclipse-temurin:17-jdknikolaik/python-nodejs:python3.12-nodejs22golang:1.21-bookwormPull (multi-arch manifest)
# Each variant is a multi-arch manifest supporting both amd64 and arm64 docker pull ghcr.io/openhands/agent-server:d872b05-pythonRun
All tags pushed for this build
About Multi-Architecture Support
d872b05-python) is a multi-arch manifest supporting both amd64 and arm64d872b05-python-amd64) are also available if needed