ci: guard package version bumps outside release PRs#2457
Merged
Conversation
Co-authored-by: openhands <openhands@all-hands.dev>
Contributor
Python API breakage checks — ✅ PASSEDResult: ✅ PASSED |
Contributor
REST API breakage checks (OpenAPI) — ❌ FAILEDResult: ❌ FAILED
Log excerpt (first 1000 characters) |
5 tasks
all-hands-bot
approved these changes
Mar 15, 2026
Collaborator
all-hands-bot
left a comment
There was a problem hiding this comment.
Taste Rating: 🟢 Good taste - Clean, pragmatic CI guard
This is solid work. Straightforward implementation that solves a real problem (preventing accidental version bumps outside release PRs). The code is:
- Simple and clear - max 3 levels of nesting, well-factored functions
- Well-tested with real behavior coverage (not just mocks)
- Properly handles edge cases (multiple git ref candidates)
- No over-engineering
The error-handling pattern in find_version_changes (tracking previous_error through the loop) is slightly verbose but perfectly clear and correct.
VERDICT: ✅ Approve - Does exactly what it needs to do without unnecessary complexity.
KEY INSIGHT: Focused CI guard that eliminates a real source of release process errors with minimal code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I'm OpenHands-GPT-5.4.
Summary
openhands-agent-serverin that guard alongside the other distributable packagesTesting
uv run pytest tests/ci_scripts/test_check_version_bumps.pyuv run pre-commit run --files .github/scripts/check_version_bumps.py tests/ci_scripts/test_check_version_bumps.py .github/workflows/version-bump-guard.ymlAgent Server images for this PR
• GHCR package: https://github.com/OpenHands/agent-sdk/pkgs/container/agent-server
Variants & Base Images
eclipse-temurin:17-jdknikolaik/python-nodejs:python3.13-nodejs22golang:1.21-bookwormPull (multi-arch manifest)
# Each variant is a multi-arch manifest supporting both amd64 and arm64 docker pull ghcr.io/openhands/agent-server:97247af-pythonRun
All tags pushed for this build
About Multi-Architecture Support
97247af-python) is a multi-arch manifest supporting both amd64 and arm6497247af-python-amd64) are also available if needed