fix(sdk): add versioned persisted AgentSettings migrations#2789
Draft
fix(sdk): add versioned persisted AgentSettings migrations#2789
Conversation
Add an SDK-owned migration flow for persisted AgentSettings payloads. Legacy unversioned settings now load as v1 and are re-serialized into the canonical v2 {version, settings} envelope via AgentSettings.load_persisted() and dump_persisted().
Co-authored-by: openhands <openhands@all-hands.dev>
Contributor
Python API breakage checks — ✅ PASSEDResult: ✅ PASSED |
Contributor
REST API breakage checks (OpenAPI) — ✅ PASSEDResult: ✅ PASSED |
Co-authored-by: openhands <openhands@all-hands.dev>
Contributor
Co-authored-by: openhands <openhands@all-hands.dev>
Contributor
Author
|
|
I'm on it! neubig can track my progress at all-hands.dev |
Co-authored-by: openhands <openhands@all-hands.dev>
Contributor
Author
|
Addressed in 5ee469c.
I'm updating OpenHands/OpenHands#13306 next to use the wrapper-based persisted format. This comment was created by an AI assistant (OpenHands) on behalf of the user. |
|
Final update since my last summary:
Conciseness check:
So yes: the requested work has now been fully addressed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AgentSettingspersistence contract with SDK-owned version migration helpersAgentSettings.migrate_persisted_payload(),load_persisted(), anddump_persisted()so consumers migrate before validation and re-save the latest canonical formTesting
uv run pre-commit run --files openhands-sdk/openhands/sdk/settings/model.py tests/sdk/test_settings.pyuv run pre-commit run --files AGENTS.mduv run pytest tests/sdk/test_settings.py -qFixes #2788
This PR was created by an AI assistant (OpenHands) on behalf of the user.
@neubig can click here to continue refining the PR
Agent Server images for this PR
• GHCR package: https://github.com/OpenHands/agent-sdk/pkgs/container/agent-server
Variants & Base Images
eclipse-temurin:17-jdknikolaik/python-nodejs:python3.13-nodejs22-slimgolang:1.21-bookwormPull (multi-arch manifest)
# Each variant is a multi-arch manifest supporting both amd64 and arm64 docker pull ghcr.io/openhands/agent-server:c8073b0-pythonRun
All tags pushed for this build
About Multi-Architecture Support
c8073b0-python) is a multi-arch manifest supporting both amd64 and arm64c8073b0-python-amd64) are also available if needed