test: add additional regression tests for restore_metrics telemetry sync (#13843)#2793
Conversation
|
Hi!
Thanks for the heads-up!
Since this is my first-ever PR, I'd be more than happy to see my tests
merged into the codebase. :-)
Vasco Schiavo ***@***.***> 于2026年4月10日周五 16:44写道:
… *VascoSch92* left a comment (OpenHands/software-agent-sdk#2793)
<#2793 (comment)>
Hey @Jinhaooo <https://github.com/Jinhaooo>
Thanks for your contribution!
We actually had this bug in the SDK already, and I merged a fix this
morning just before seeing your PR (see #2736
<#2736> and #2459
<#2459>).
However, if you'd like to rebase on main, we would still love to merge the
tests you wrote! :-)
—
Reply to this email directly, view it on GitHub
<#2793 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BIW2UI5SLSN4OJ7VPO3H73L4VCYARAVCNFSM6AAAAACXTQWHOGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DEMRSGMYDMMZVG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Cool... So please merge your tests with the tests I added :-). You can ping me for a review |
Add edge-case tests complementing test_issue_2459_restore_metrics_syncs_telemetry: - cost propagation through telemetry after restore - stale metrics isolation (original object not updated) - telemetry=None safety guard - end-to-end ConversationStats integration Related issue: OpenHands/OpenHands#13843 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
23303b7 to
477486c
Compare
|
Rebased on main and removed the duplicate test. Four new test cases remain that cover scenarios not in the existing test. Ready for review @VascoSch92! |
|
Just one last thing and then we are good to merge. Please add these tests under my test: test_issue_2459_restore_metrics_syncs_telemetry(). |
Move the 4 additional regression tests next to test_issue_2459_restore_metrics_syncs_telemetry and remove the separate test_restore_metrics_telemetry_sync.py file. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Done! @VascoSch92 |
Summary
The fix for restore_metrics() telemetry desync was merged in #2736. This PR adds additional regression tests that complement the existing
test_issue_2459_restore_metrics_syncs_telemetrytest with edge-case coverage:Test plan
pytest tests/sdk/llm/test_restore_metrics_telemetry_sync.pypytest tests/sdk/llm/test_llm.pyRelated issue: OpenHands/OpenHands#13843
🤖 Generated with Claude Code