feat: server-side ExtensionConfig support, deprecate AgentContext loading fields#2857
Closed
csmith49 wants to merge 1 commit intofeat/conversation-extension-configfrom
Closed
feat: server-side ExtensionConfig support, deprecate AgentContext loading fields#2857csmith49 wants to merge 1 commit intofeat/conversation-extension-configfrom
csmith49 wants to merge 1 commit intofeat/conversation-extension-configfrom
Conversation
…ding fields Server request model: - Add extension_config field to _StartConversationRequestBase - Flows through StoredConversation automatically via inheritance Event service: - Forward extension_config from StoredConversation to LocalConversation - Legacy plugins/hook_config still passed for backward compat AgentContext deprecation: - load_user_skills, load_public_skills, marketplace_path now carry deprecated Field metadata (deprecated_in=1.18.0, removed_in=1.23.0) - _load_auto_skills model_validator emits warn_deprecated() when these fields are set to non-default values - Fields still function for backward compatibility during the deprecation window Examples: - 03_activate_skill: move load_public_skills to ExtensionConfig on Conversation - 01_loading_agentskills: remove redundant load_public_skills=False Tests: - 3 new server tests: extension_config field exists, flows through StoredConversation, defaults to None Co-authored-by: openhands <openhands@all-hands.dev>
Contributor
Coverage Report •
|
||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Server-side integration of
ExtensionConfigand deprecation of legacyAgentContextloading fields.Changes
Server request model:
extension_configfield to_StartConversationRequestBaseStoredConversationautomatically via inheritanceEvent service:
extension_configfromStoredConversationtoLocalConversationplugins/hook_configstill passed for backward compatAgentContext deprecation:
load_user_skills,load_public_skills,marketplace_pathnow carry deprecatedFieldmetadata (deprecated_in=1.18.0,removed_in=1.23.0)_load_auto_skillsmodel_validator emitswarn_deprecated()when these fields are set to non-default valuesExamples:
03_activate_skill: moveload_public_skillstoExtensionConfigon Conversation01_loading_agentskills: remove redundantload_public_skills=FalseTests:
extension_configfield exists, flows throughStoredConversation, defaults to NoneStack
feat/conversation-extension-config→feat/extension-config-modelfeat/extension-config-model→refactor/mcp-merge-to-mcp-moduleopenhands.sdk.mcp#2848refactor/mcp-merge-to-mcp-module→feat/installed-extensionsfeat/installed-extensions→mainThis PR was created by an AI assistant (OpenHands) on behalf of the user.