Harden reviewer eligibility for auto-assigned PR reviews#2874
Draft
Harden reviewer eligibility for auto-assigned PR reviews#2874
Conversation
Co-authored-by: openhands <openhands@all-hands.dev>
Contributor
Python API breakage checks — ✅ PASSEDResult: ✅ PASSED |
Contributor
REST API breakage checks (OpenAPI) — ✅ PASSEDResult: ✅ PASSED |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The
assign-reviewsworkflow relies on a generic agent prompt for reviewer selection. In PR #2842, that flow assigned a reviewer on a Dependabot PR even though the reviewer does not appear to have commit history in this repo, which suggests the prompt allowed the agent to fall back to any maintainer/collaborator with write access.Summary
AGENTS.mdIssue Number
N/A — follow-up to #2842 (comment)
How to Test
I validated that both edited workflow files still parse as YAML:
I did not run the workflow end-to-end locally because the behavior depends on live GitHub state plus the hosted agent/task runner.
Video/Screenshots
N/A
Type
Notes
This keeps the existing prompt-driven workflow but makes the reviewer eligibility checks much more explicit and API-verifiable, which should reduce the chance of assigning arbitrary maintainers on bot-authored dependency PRs.
This PR was created by an AI assistant (OpenHands) on behalf of the user.
Agent Server images for this PR
• GHCR package: https://github.com/OpenHands/agent-sdk/pkgs/container/agent-server
Variants & Base Images
eclipse-temurin:17-jdknikolaik/python-nodejs:python3.13-nodejs22-slimgolang:1.21-bookwormPull (multi-arch manifest)
# Each variant is a multi-arch manifest supporting both amd64 and arm64 docker pull ghcr.io/openhands/agent-server:63dba31-pythonRun
All tags pushed for this build
About Multi-Architecture Support
63dba31-python) is a multi-arch manifest supporting both amd64 and arm6463dba31-python-amd64) are also available if needed