fix(ci): pass extensions-version so sub-agent review script is used#2890
Merged
fix(ci): pass extensions-version so sub-agent review script is used#2890
Conversation
The pr-review workflow uses @feat/pr-review-sub-agent-delegation for the action definition, but the action.yml checks out the extensions repo at extensions-version (default: main) for the actual script. Since extensions#164 is not merged to main yet, the script from main has no sub-agent code — so USE_SUB_AGENTS=true is silently ignored. Fix: explicitly set extensions-version: feat/pr-review-sub-agent-delegation so the checkout matches the action branch and the sub-agent code path is actually available at runtime. Co-authored-by: openhands <openhands@all-hands.dev>
Contributor
Python API breakage checks — ✅ PASSEDResult: ✅ PASSED |
Contributor
REST API breakage checks (OpenAPI) — ✅ PASSEDResult: ✅ PASSED |
all-hands-bot
approved these changes
Apr 20, 2026
Collaborator
all-hands-bot
left a comment
There was a problem hiding this comment.
LGTM! Clean fix aligning the script checkout with the action branch. The comments clearly explain the temporary workaround until extensions#164 merges to main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The PR review workflow points to
@feat/pr-review-sub-agent-delegationfor the action definition and setsuse-sub-agents: true, but the action'saction.ymlchecks out the extensions repo atextensions-version(which defaults tomain) for the actual Python script it runs:Since OpenHands/extensions#164 hasn't been merged to
mainyet, the script that actually executes is the oldmainbranch version (~928 lines) which has no sub-agent code — not the feature branch version (~1062 lines).Evidence from PR #2886 CI logs:
USE_SUB_AGENTS=trueis set ✅@feat/pr-review-sub-agent-delegation✅[terminal, file_editor, task_tracker]— noTaskToolSet❌Fix
Explicitly pass
extensions-version: feat/pr-review-sub-agent-delegationso the checkout matches the action branch and the sub-agent code is available at runtime.This PR was created by an AI assistant (OpenHands) on behalf of the user.
@xingyaoww can click here to continue refining the PR
Agent Server images for this PR
• GHCR package: https://github.com/OpenHands/agent-sdk/pkgs/container/agent-server
Variants & Base Images
eclipse-temurin:17-jdknikolaik/python-nodejs:python3.13-nodejs22-slimgolang:1.21-bookwormPull (multi-arch manifest)
# Each variant is a multi-arch manifest supporting both amd64 and arm64 docker pull ghcr.io/openhands/agent-server:ad109e1-pythonRun
All tags pushed for this build
About Multi-Architecture Support
ad109e1-python) is a multi-arch manifest supporting both amd64 and arm64ad109e1-python-amd64) are also available if needed