Skip to content

Implement CRSF spec for TYPE_FOLDER#473

Open
ajjjjjjjj wants to merge 3 commits intomasterfrom
janek/crsf-spec-update
Open

Implement CRSF spec for TYPE_FOLDER#473
ajjjjjjjj wants to merge 3 commits intomasterfrom
janek/crsf-spec-update

Conversation

@ajjjjjjjj
Copy link
Member

@ajjjjjjjj ajjjjjjjj commented Apr 10, 2025

  • remember only first and last child id,
  • load only between first and last child id,
  • skip querying folder items for root folder,

Closes #461

@ajjjjjjjj ajjjjjjjj changed the title Adjust ELRS to CRSF spec for TYPE_FOLDER, Adjust ELRS to CRSF spec for TYPE_FOLDER Apr 10, 2025
@ajjjjjjjj ajjjjjjjj force-pushed the janek/crsf-spec-update branch 2 times, most recently from 5a1a1bc to 11a900c Compare October 24, 2025 15:21
@ajjjjjjjj ajjjjjjjj changed the title Adjust ELRS to CRSF spec for TYPE_FOLDER IMplement CRSF spec for TYPE_FOLDER Oct 24, 2025
@ajjjjjjjj ajjjjjjjj changed the title IMplement CRSF spec for TYPE_FOLDER Implement CRSF spec for TYPE_FOLDER Oct 24, 2025
@ajjjjjjjj ajjjjjjjj force-pushed the janek/crsf-spec-update branch from 11a900c to c4cd346 Compare January 18, 2026 21:13
@ajjjjjjjj ajjjjjjjj marked this pull request as ready for review January 18, 2026 21:28
@ajjjjjjjj
Copy link
Member Author

ajjjjjjjj commented Feb 3, 2026

I have tested on standard TX and RX, seems to work fine and adds noticeable speedup especially for lower pocket rates.

@wimalopaan, would you mind - i know you have some non standard CRSF devices that may be good to test this with for loading speedup and possible regressions.

@wimalopaan
Copy link

I have tested on standard TX and RX, seems to work fine and adds noticeable speedup especially for lower pocket rates.

@wimalopaan, would you mind - i know you have some non standard CRSF devices that may be good to test this with for loading speedup and possible regressions.

Very cool!
Will try that asap, but that'll happen not before the next weekend ...

@ajjjjjjjj ajjjjjjjj force-pushed the janek/crsf-spec-update branch from ec19f90 to 8c3abf2 Compare February 5, 2026 11:24
@wimalopaan
Copy link

I justed this successfully! Very good.

Although I did not test that with a LA attached, I have the impression, that the tree of parameters is queried in a depth-first manner instead of a breadth-first manner.
Also, if a subfolder is opened (queried) it looks that the sibling folders are also queried, although they are not visible.

So, in general it looks that TBS agent is still faster an more efficient because only the visible folder elements are queried. Clearly, this is only possible, if the devices stick to the TBS specs for foldern containing the IDs of the children.

https://github.com/tbs-fpv/tbs-crsf-spec/blob/main/crsf.md#0x28-parameter-ping-devices

Maybe there is still some room for optimization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adapt CRSF implementation to TBS CRSF specs

2 participants