💄♻️：keep the page shell in one place - #1854
Merged
Merged
Conversation
✅ Deploy Preview for gh-pages-openinf ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
DerekNonGeneric
force-pushed
the
refactor/page-shell
branch
from
August 24, 2026 05:22
424a673 to
9563c2f
Compare
Six stylesheets each carried their own `.wrap`, their own room for the footer, their own link color and focus ring. All six said the same thing in six spellings, and a seventh page would have said it again. They now read one `_shell.scss`. The error page, which centers against the viewport and has no flow to pad, is the one exception and says so. `_home.scss` declared `.band` and `.section-head` without a prefix, and every page uses those names. Both were the shell's rule already, once `.band`'s own tighter value turned out to be a leftover from before the shell existed rather than a choice, so both are gone. No selector in any page stylesheet reaches another page now. 72 page-scoped declarations became 8 shared ones. Three differ from before, and all three are the same value written another way. Signed-off-by: Derek Lewis <DerekNonGeneric@inf.is> Assisted-by: Claude-Code:claude-opus-5
DerekNonGeneric
force-pushed
the
refactor/page-shell
branch
from
August 24, 2026 05:44
9563c2f to
5ca0eeb
Compare
OpenINFbot
approved these changes
Aug 24, 2026
openinf-commit-queue
Bot
removed
the
commit-queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Six stylesheets each carried their own copy of the page shell:
.wrap, theroom a page leaves for the footer, the link color, the focus ring, and the
section furniture. All six said the same thing in six spellings —
$docs-wrap,$about-wrap,$doc-wrap,--wrap— and every one resolved to1200px.They now read one
_shell.scss. 196 lines removed; 60 added, 59 of them the new file.The bug this closes
_home.scssdeclared.bandand.section-headwith no prefix, at (0,1,0).Every page uses those names, so the home page's rules were in scope on all of
them. Nothing was visibly wrong, because each page happened to override every
property home set — but a property added to one of those rules would have
landed on five pages at once.
.section-headwas the shell's rule already, to the character, and is gone..band's tighter value on the home page turned out to be a leftover frombefore the shell existed rather than a deliberate choice, so it goes too — the
gap is nothing at mobile and 4px at desktop, and now matches
.sdk-bodyright above it on the same page.
Checked afterwards: no selector in any page stylesheet reaches a page it does
not belong to.
Verification
The compiled stylesheet was captured before and after and compared
declaration by declaration. 72 page-scoped declarations became 8 shared ones,
and three values differ:
.section-headborder2px solid var(--ink)2px solid #1d1916.section-morefontvar(--mono)Both are the same value written another way.
.bandmoved to the shell'sclamp(2.5rem, 6vw, 4rem)outright, home included.nps testpasses, all 18.Left alone
_pages.jsonstill namespage.liquidas the default layout, and_custom.scssstill stylesmain > .containerfor it. Nothing uses either —every page sets
layout: default— so this is the old shell sitting dormant.Worth knowing that a page reviving it would now take the shell's
padding-bottomon top of the container's own. Not touched here, sincewhether that layout has a future is a decision rather than a refactor.