Skip to content

idr support for greg09 + fw #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
henkwiedig merged 10 commits into from
Jan 6, 2026
Merged

idr support for greg09 + fw #110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
6f570c8
Add gregidr probes and target build helper
sickgreg Jan 2, 2026
c1f45ab
Stop repeated IDR bursts after confirmation
sickgreg Jan 2, 2026
bbaf728
Adjust record-start IDR retries
sickgreg Jan 2, 2026
f78922c
Merge pull request #1 from sickgreg/fix/record-idr-burst-retry
sickgreg Jan 2, 2026
b05d10d
removed unused run file
henkwiedig Jan 2, 2026
b151ef4
make idr_ * api c-compatible
henkwiedig Jan 2, 2026
32b8da0
add gsmenu toggle
henkwiedig Jan 2, 2026
bf62d3a
add test build dependencies
henkwiedig Jan 2, 2026
9e16492
drop build_on_target.sh
henkwiedig Jan 4, 2026
e976d0b
Merge pull request #2 from henkwiedig/idr-request
sickgreg Jan 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,8 @@ else()
)
pkg_search_module(gstreamer REQUIRED IMPORTED_TARGET gstreamer-1.0>=1.4)
pkg_search_module(gstreamer-app REQUIRED IMPORTED_TARGET gstreamer-app-1.0>=1.4)
pkg_search_module(gstnet REQUIRED IMPORTED_TARGET gstreamer-net-1.0>=1.4)
pkg_search_module(gio REQUIRED IMPORTED_TARGET gio-2.0)

add_executable(${PROJECT_NAME} ${SOURCE_FILES})

Expand All @@ -212,6 +214,8 @@ else()
${PNG_LIBRARIES}
PkgConfig::gstreamer
PkgConfig::gstreamer-app
PkgConfig::gstnet
PkgConfig::gio
Copy link
Collaborator

@henkwiedig henkwiedig Jan 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need this also in the test build down below

)
endif()

Expand Down Expand Up @@ -257,7 +261,9 @@ if(BUILD_TESTS)
)
pkg_search_module(gstreamer REQUIRED IMPORTED_TARGET gstreamer-1.0>=1.4)
pkg_search_module(gstreamer-app REQUIRED IMPORTED_TARGET gstreamer-app-1.0>=1.4)
target_link_libraries(pixelpilot_tests PkgConfig::gstreamer PkgConfig::gstreamer-app)
pkg_search_module(gstnet REQUIRED IMPORTED_TARGET gstreamer-net-1.0>=1.4)
pkg_search_module(gio REQUIRED IMPORTED_TARGET gio-2.0)
target_link_libraries(pixelpilot_tests PkgConfig::gstreamer PkgConfig::gstreamer-app PkgConfig::gstnet PkgConfig::gio)

target_link_options(pixelpilot_tests
BEFORE PUBLIC -fsanitize=undefined PUBLIC -fsanitize=address
Expand Down
16 changes: 10 additions & 6 deletions src/dvr.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,9 +134,11 @@ void Dvr::loop() {
if (dvr_file != NULL) {
break;
}
start();
if (video_frm_width > 0 && video_frm_height > 0) {
init();
if (start() == 0) {
idr_request_record_start();
if (video_frm_width > 0 && video_frm_height > 0) {
init();
}
}
break;
}
Expand All @@ -153,9 +155,11 @@ void Dvr::loop() {
{
SPDLOG_DEBUG("got rpc TOGGLE");
if (dvr_file == NULL) {
start();
if (video_frm_width > 0 && video_frm_height > 0) {
init();
if (start() == 0) {
idr_request_record_start();
if (video_frm_width > 0 && video_frm_height > 0) {
init();
}
}
} else {
stop();
Expand Down
14 changes: 14 additions & 0 deletions src/gsmenu/gs_system.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
#include <stdlib.h>
#include <string.h>
#include "../main.h"
#include "../gstrtpreceiver.h"
#include "gs_system.h"
#include "lvgl/lvgl.h"
#include "helper.h"
Expand All @@ -18,6 +19,7 @@ lv_obj_t * resolution;
lv_obj_t * rec_enabled;
lv_obj_t * rec_fps;
lv_obj_t * vsync_disabled;
lv_obj_t * gs_request_idr;
lv_obj_t * video_scale;

extern lv_obj_t * ap_fpv_ssid;
Expand Down Expand Up @@ -47,6 +49,8 @@ void gs_system_page_load_callback(lv_obj_t * page)
if (disable_vsync) lv_obj_add_state(lv_obj_get_child_by_type(vsync_disabled,0,&lv_switch_class), LV_STATE_CHECKED);
else lv_obj_clear_state(lv_obj_get_child_by_type(vsync_disabled,0,&lv_switch_class), LV_STATE_CHECKED);

if (idr_get_enabled()) lv_obj_add_state(lv_obj_get_child_by_type(gs_request_idr,0,&lv_switch_class), LV_STATE_CHECKED);
else lv_obj_clear_state(lv_obj_get_child_by_type(gs_request_idr,0,&lv_switch_class), LV_STATE_CHECKED);
}

void toggle_rec_enabled()
Expand Down Expand Up @@ -86,6 +90,14 @@ void disable_vsync_cb(lv_event_t *e) {
}
}

void gs_request_idr_cb(lv_event_t *e) {
lv_event_code_t event = lv_event_get_code(e);
if (event == LV_EVENT_VALUE_CHANGED) {
lv_obj_t *ta = lv_event_get_target(e);
idr_set_enabled(lv_obj_has_state(ta, LV_STATE_CHECKED));
}
}

void rec_fps_cb(lv_event_t *e) {
lv_event_code_t event = lv_event_get_code(e);
if (event == LV_EVENT_VALUE_CHANGED) {
Expand Down Expand Up @@ -146,6 +158,8 @@ void create_gs_system_menu(lv_obj_t * parent) {

vsync_disabled = create_switch(cont,LV_SYMBOL_SETTINGS,"Disable VSYNC","disable_vsync", NULL,false);
lv_obj_add_event_cb(lv_obj_get_child_by_type(vsync_disabled,0,&lv_switch_class), disable_vsync_cb, LV_EVENT_VALUE_CHANGED,NULL);
gs_request_idr = create_switch(cont,LV_SYMBOL_SETTINGS,"Request IDR","gs_request_idr", NULL,false);
lv_obj_add_event_cb(lv_obj_get_child_by_type(gs_request_idr,0,&lv_switch_class), gs_request_idr_cb, LV_EVENT_VALUE_CHANGED,NULL);

create_text(parent, NULL, "Recording", NULL, NULL, false, LV_MENU_ITEM_BUILDER_VARIANT_1);
section = lv_menu_section_create(parent);
Expand Down
Loading